Closed Bug 887908 Opened 11 years ago Closed 10 years ago

There are two close buttons for sidebars

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 28

People

(Reporter: evold, Assigned: Gijs)

References

Details

(Keywords: regression, Whiteboard: [Australis:M8][Australis:P2])

Attachments

(2 files)

2 close buttons for sidebars
33.80 KB, image/png
Details
Patch v1
984 bytes, patch
mconley
: review+
Details | Diff | Splinter Review 
See attached screen shot.
Whiteboard: [Australis:M?][Australis:P3]
Whiteboard: [Australis:M?][Australis:P3] → [Australis:M?]
Component: Toolbars and Customization → Theme
Keywords: regression
Whiteboard: [Australis:M?] → [Australis:M?][Australis:P2]
Note that this appears to be a Retina-only bug.
Stealing this
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attached patch Patch v1 — — Splinter Review 
This works for me, and is net code-removal, too! Hurray? :-)

The slightly sad bit about this is that the close-sidebar.png image is now wholly unused on browser - but after a quick check of comm-central, still used by calendar/ (possibly amongst others? Thunderbird?), so removing it from toolkit before we have done the merge-that-wont-be-backed-out is probably not a workable idea.
Attachment #773907 - Flags: review?(mconley)
Comment on attachment 773907 [details] [diff] [review]
Patch v1

Review of attachment 773907 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for catching this. :) Fix looks good to me.
Attachment #773907 - Flags: review?(mconley) → review+
https://hg.mozilla.org/projects/ux/rev/47dbbf9e4c5d
Whiteboard: [Australis:M?][Australis:P2] → [Australis:M8][Australis:P2][fixed-in-ux]
(In reply to :Gijs Kruitbosch from comment #3)
> The slightly sad bit about this is that the close-sidebar.png image is now
> wholly unused on browser - but after a quick check of comm-central, still
> used by calendar/ (possibly amongst others? Thunderbird?), so removing it
> from toolkit before we have done the merge-that-wont-be-backed-out is
> probably not a workable idea.

File a bug on removing it then?
Blocks: 894490
https://hg.mozilla.org/mozilla-central/rev/47dbbf9e4c5d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M8][Australis:P2][fixed-in-ux] → [Australis:M8][Australis:P2]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.