887951 - Update panel menu button tooltip

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Matthew N. [:MattN]]

"Customize and Control UX" isn't user-friendly.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

To fix this bug, you'll need to clone the repository at https://hg.mozilla.org/projects/ux/.

Matej, clicking on this button brings the user to the "Firefox" menu, which allows for making changes to Firefox (Full Screen, Preferences, Customize) as well as operating Firefox (New Window, Save Page, Exit) etc. Can you think of something better than "Customize and Control brandShortName"?

Comment 2

[Matej Novak [:matej]]

Can I get a little more context as to where this appears and what the issue is with the current string? Thanks.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

This appears when hovering over the menu button in Nightly UX builds.

Matt filed the bug, so I'll defer to him about what is wrong with the current string.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Matej - if you come over to my desk, I can show you the tooltip in context.

Comment 5

[Madhava Enros [:madhava]]

I call this button the "Menu Button" in that it brings up the menu.

One approach would be to have the tooltip just reflect that -- i.e., "Menu," "Tools Menu," or "Firefox Menu."

Another would be to be more descriptive -- i.e., "Tools and Customization."

Comment 6

[Matej Novak [:matej]]

I think something like the options in comment 5 could work, I just worry that "tools" may not be the best descriptor. Maybe something like "preferences" instead?

My other thought was to make this more actionable and less descriptive. It could even be, dare I say it, a tad whimsical.

Maybe it's something like "Mission control" or "Tweaks & fiddles."

I believe mconley is also reaching out to product marketing so we can all get on the same page about what this menu should be called — whether or not we use that for the tooltip.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

(In reply to Matej Novak [:matej] from comment #6)
> I believe mconley is also reaching out to product marketing so we can all
> get on the same page about what this menu should be called — whether or not
> we use that for the tooltip.

What I ended up doing was asking in the Australis weekly meeting, which got Madhava in here. Asa was also in the call, and didn't pipe up mentioning a particular name that Product was interested in pushing, so I think Madhava's data is stuff we can run with.

Comment 8

[Matthew N. [:MattN]]

To be honest, when I filed the bug, I thought that "UX" was hard-coded as a temporary tooltip and not &brandShortName;. The other aspect was that I thought it was putting a bit too much emphasis on customization considering that it's not a very common task.

Comment 9

[Matthew N. [:MattN]]

While somewhat boring, I think "Firefox Menu" or simply "Menu" is the most straightforward.

Comment 10

[Manish Goregaokar [:manishearth]]

Attachment: Patch 0.1

Changed text to "Tools and Customization"

Comment 11

[Manish Goregaokar [:manishearth]]

Attachment: 887951.patch

Oops, forgot to edit in the directory in the previous patch (had a build running, so I couldn't hg at the root level and had to edit the diff manually).

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 795060 [details] [diff] [review]
887951.patch

I'm not sure if we've settled on a name yet.

The options so far are:
1. Tools and Customization
2. Customize and control Firefox
3. Customize and Control Firefox
4. Mission control
5. Tweaks & fiddles
6. Menu

Madhava, I'll let you make the call here. Which one should we use?

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Manish, Madhava is on vacation for the next two weeks, so I'm not expecting an answer very soon from him.

I will try to find another bug for you to work on in the meantime, so far your first patch looks good!

Comment 14

[Matthew N. [:MattN]]

(In reply to Jared Wein [:jaws] from comment #12)
You forgot some from Madhava in comment 5:
> The options so far are:
> 1. Tools and Customization
> 2. Customize and control Firefox
> 3. Customize and Control Firefox
> 4. Mission control
> 5. Tweaks & fiddles
> 6. Menu
  7. Firefox Menu
  8. Tools Menu

> Madhava, I'll let you make the call here. Which one should we use?

Comment 15

[Manish Goregaokar [:manishearth]]

Alright, thanks :)

Comment 16

[Mike Conley (:mconley) (:⚙️)]

Any decision on this yet?

Comment 17

[Madhava Enros [:madhava]]

We should look at this together with the extra tip in bug 870593.

Where by we, I mean I. And Mnovak.

Comment 18

[Matej Novak [:matej]]

Madhava and I chatted about this today and here's what we came up with:

Open menu

Comment 19

[Manish Goregaokar [:manishearth]]

> Open menu


Isn't that a bit redundant?

Comment 20

[Manish Goregaokar [:manishearth]]

Attachment: open.menu.patch

Patch for "open menu"

Comment 21

[Mike de Boer [:mikedeboer]]

Comment on attachment 8365494 [details] [diff] [review]
open.menu.patch

Since this is a code change, it's best to let a developer look at this. That, and Jared is your mentor on this one!

Comment 22

[Manish Goregaokar [:manishearth]]

Ah, I thought the code change had been vetted, it was just the wording change that mattered.

Thanks.

Comment 23

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8365494 [details] [diff] [review]
open.menu.patch

Review of attachment 8365494 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Manish, thanks for the patch. Because this text has been on mozilla-central already, we'll need to also change the entity name in the dtd. You can use appmenu.title2

Comment 24

[Manish Goregaokar [:manishearth]]

Attachment: tooltip.patch

Changed all instances of `appmenu.title` to `appmenu.title2` to trigger l10n changes.

Comment 25

[Dão Gottwald [:dao]]

Comment on attachment 8365950 [details] [diff] [review]
tooltip.patch

>       <toolbaritem id="PanelUI-button"
>                    class="chromeclass-toolbar-additional"
>                    removable="false"
>-                   title="&appmenu.title;">
>+                   title="&appmenu.title2;">
>         <toolbarbutton id="PanelUI-menu-button"
>                        class="toolbarbutton-1"
>                        label="&brandShortName;"
>-                       tooltiptext="&appmenu.title;"/>
>+                       tooltiptext="&appmenu.title2;"/>
>       </toolbaritem>

As far as I can tell, the title attribute on the toolbaritem node is completely useless; you should drop it and call the entity appmenu.tooltip.

Comment 26

[Manish Goregaokar [:manishearth]]

Attachment: tooltip.patch

Comment 27

[Manish Goregaokar [:manishearth]]

What does this bug have to do with customization mode? O.o

Comment 28

[Mike Conley (:mconley) (:⚙️)]

Whoops - typed in the wrong bug number. Thanks for the catch. :)

Comment 29

[Dão Gottwald [:dao]]

Comment on attachment 8366007 [details] [diff] [review]
tooltip.patch

>Bug 887951 - Update panel menu button tooltip; r=jaws

nit: r=dao since I ended up granting you review

Comment 30

[Manish Goregaokar [:manishearth]]

Attachment: tooltip.patch

Comment 31

[Dão Gottwald [:dao]]

Comment on attachment 8366125 [details] [diff] [review]
tooltip.patch

thanks, this wouldn't have needed another review

Comment 32

[Mike Conley (:mconley) (:⚙️)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/39fd448f1994

Comment 33

[Mike Conley (:mconley) (:⚙️)]

...aaand backed out because it didn't have Australis in the commit message.

https://hg.mozilla.org/integration/fx-team/rev/4744ddc205df

and then relanded with a better commit message:

https://hg.mozilla.org/integration/fx-team/rev/14063a5b30e2

Comment 34

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/14063a5b30e2