888003 - Simple Push - The network connection timeout for navigator.push.register is too aggressive, so registration will fail too quickly on weak networks

Status: RESOLVED INVALID

(Firefox OS Graveyard :: General, defect)

Description

[Jason Smith [:jsmith]]

Build: B2G 18 6/27/2013
Device: Unagi

STR

1. Connect to Mozilla Guest wifi (aka bad network)
2. Try to call navigator.push.register

Expected

We should have a long enough timeout to handle weak network conditions.

Actual

We fail too quickly under weak network conditions such as Mozilla Guest, resulting on an onerror callback firing with a timeout error. We should make the timeout length a bit longer to handle weak networks.

Comment 1

[Doug Turner (:dougt)]

nsm, what is the timeout here for the xhr?

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

(In reply to Doug Turner (:dougt) from comment #1)
> nsm, what is the timeout here for the xhr?

It's 10 seconds.

Comment 3

[Jason Smith [:jsmith]]

After doing more recent testing in the test run, I think 10 seconds might be okay given that a web developer could easily re-query via register if an onerror callback fires due to a loss of connection. As such, I'm closing this out.

Comment 4

[JR Conlin [:jrconlin,:jconlin]]

One thing to also consider is that a potential dDoS exists if griefers attempt idle connections to the PushServer. I plan on adding a timeout on the server that drops the channel if no "hello" is recv'd within an allotted time.