888007 - [Clock] Lazy load banner view

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Kevin Grandon :kgrandon]

There are yet a few small wins we can have in the clock app. One of these wins would be to lazy load the banner view JS. It appears we only use this when creating an alarm.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Hi Mike, pretty simple clock patch if you have time. Just moves stuff around. Thanks!

Comment 2

[Mike Lee [:mlee]]

Good initiative Kevin. Can you quantify the gains, i.e. the ms gained by making these kinds of changes?

Comment 3

[Kevin Grandon :kgrandon]

Gains here are minor, maybe 5 to 10 ms off the initial startup path. But there are also some steps to split out some other javascript which we should be able to lazy load down the road. I'm looking into it now, but it's likely a larger patch.

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 768578 [details]
Github pull request pointer

Looks good. Everything still working on my Unagi.

Merged: 163b3c144a3d457a5c7d6def8dd15fc1a139b903

Comment 5

[Rick Waldron [:rwaldron]]

Requesting leo+ because an leo+ patch depends on these changes

Comment 6

[Jason Smith [:jsmith]]

(In reply to Rick Waldron from comment #5)
> Requesting leo+ because an leo+ patch depends on these changes

Triage - this is not a blocker for leo as this is not a required 1.1 performance requirement. You should build a branch-specific patch for bug 882751 that does not depend on these changes.