888089 - topcrasher CSV broken (looking for is_gc_count)

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Helmer [:rhelmer]]

https://crash-stats.mozilla.com/topcrasher/products/Firefox/versions/25.0a1/crash_type/report/os_name/browser?format=csv is failing

https://errormill.mozilla.org/webtools/socorro-crashstats-prod/group/16587/

KeyError: 'is_gc_count'

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "crashstats/crashstats/decorators.py", line 48, in inner
    return view(request, *args, **kwargs)
  File "session_csrf/__init__.py", line 127, in wrapper
    response = f(request, *args, **kw)
  File "crashstats/crashstats/decorators.py", line 32, in inner
    return view(request, *args, **kwargs)
  File "crashstats/crashstats/views.py", line 309, in topcrasher
    return _render_topcrasher_csv(request, context, product)
  File "crashstats/crashstats/views.py", line 343, in _render_topcrasher_csv
    crash['is_gc_count'],

Comment 1

[Robert Helmer [:rhelmer]]

selena, r? https://github.com/mozilla/socorro-crashstats/pull/397

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/7b5f8ea781d8f218754935d1cd1c2c97943682ce
fixes bug 888089 - check for keys before using

https://github.com/mozilla/socorro-crashstats/commit/ec1060bb702695a623a39604172bf490021f76b5
Merge pull request #397 from rhelmer/bug888089-topcrasher-csv-broken

fixes bug 888089 - check for keys before using

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/617b8291aae2ffc2e2300800ad79b9d0a0f32567
fixes bug 888089 - proper arg name is uuid not crash_id

Comment 5

[Robert Helmer [:rhelmer]]

Hmm actually the commit in comment 3 should have had a different bug # - sorry about that. It really fixes problems like bug 888089

Comment 6

[Matt Brandt [:mbrandt]]

QA verified on stage - nicely done.

https://crash-stats-django.allizom.org/topcrasher/products/Firefox/versions/25.0a1/crash_type/report/os_name/browser?format=csv