888145 - onLocationChange top level window check doesn't work for "browser" webapps

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Patch v1

While looking at running Gaia in Fennec, I ran into an issue where mouse click events were never being fired. Turns out the problem was that we have a check in onLocationChange for

if (window != window.top)
  return;

This incorrectly passes here because I'm running all of the Gaia apps inside the Gaia "System" app, which essentially acts as a browser/window manager. B2G has added protections so that apps loaded inside the system app (or other browser like apps) can not reach across this new "chrome-content" boundary.

We have a better check for "Is this window the top level window in one of our tabs?". Its likely a little more expensive, but we could just use it instead.

Comment 1

[Wesley Johnston (:wesj)]

To explain why this kills clicks, if we fall through here we set tab.contentDocumentIsDisplayed = false (who named that variable?). That would normally be unset on first-paint of the page, but because its embedded inside a different page, that never fires. We apparently don't send mouse events to content before first paint anymore, so this bustage keeps them from ever firing (although we don't apply the same filter to touch events, so they work fine).

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch v2

Whoops. Wrong function.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 768773 [details] [diff] [review]
Patch v2

Do we have other checks that could be hosed because of this?

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1747bb1054c

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d1747bb1054c