888157 - [l10n] Confirmation box after sending an invite is displayed in English

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Screenshot of the problem

Reference:
https://mozillians.allizom.org/it/invite/

The box displayed after inviting someone is displayed in English.

What's strange is that the string is actually available in messages.po (line 224)
http://viewvc.svn.mozilla.org/vc/projects/l10n-misc/trunk/mozillians/locales/it/LC_MESSAGES/messages.po?revision=117383&view=markup

https://github.com/mozilla/mozillians/blob/master/apps/phonebook/templates/phonebook/invited.html#L11

Comment 1

[Francesco Lodolo [:flod]]

Still happening
https://github.com/mozilla/mozillians/blob/master/mozillians/templates/phonebook/invited.html

"XXX has been invited to Mozillians. They'll receive an email with instructions on how to join. You can invite another Mozillian if you like. "

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/c0cd48916505edf46e8236abf98dbf982d8de87a
[fix bug 888157] Correctly handle translatable strings with variables.

https://github.com/mozilla/mozillians/commit/6caca2b6843fbad9c2e061eb4ed73f7d9f3c2bf1
Merge pull request #880 from glogiotatidis/888157

[fix bug 888157] Correctly handle translatable strings with variables.

Comment 3

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: Italian confirmation of invitation.

The confirmation in staging is now using the locale in the URL. Thanks for the bug and thanks for the fix!