888245 - [SMS] With an invalid input as number, it is possible to tap on header to use the options given

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[isabelrios]

Unagi device 06/28 build:
Gecko-db60841
Gaia-508cfc8

STR
1) open message app
2) select new message 
3) add a completely invalid number made of alphabetic characters to the 'to field': 'xxx'
4) type something in the message field
5) select send 
6) Open the thread and tap on the header 

ACTUAL
Overlay opens with invalid number input in step 4) in header and 5 CTAs: 'Call', 'Send Message', 'Create new contact', 'Add to an existing contact', 'Cancel'

- Select 'Call' returns user to thread view
- Select 'Send Message' opens the New message dialogue with the invalid number in step 4) repopulated in the 'to field'. If the user adds text to the message field and selects send the new message is appended to the thread created in 5

- Select 'Create new contact' New contact dialogue opens with invalid number in step 4) repopulated in phone number field. Contact can be created, but invalid phone number cannot be called due to error alert 'The phone number you are calling is not valid'
- Select 'Add to an existing contact' the contact list is displayed, the user selects a contact and the edit contact dialogue is presented with invalid number in step 4) repopulated in phone number field. Contact can be saved but upon save every single message thread, irrespective of phone number in the inbox is assigned the name of the contact to which the invalid phone number has been assigned. 

EXPECTED
Options given when tapping on the header should not be available when the value there is not a valid one. 
It has to be correctly managed, not allowing to create a contact (or adding to an existing contact) which number would be, in the case of the example: 'xxx'

Comment 1

[Mark Shiao]

Hi Isabel,

I agree this is not an ideal user experience, however since it is ux related I would like to get UX's opinion before proceeding.  For comparison purposes, I've tested on my iphone and it provides the same experience.  You are able to create contacts from an invalid number.  I guess it's a question of how far we want to extend our dummy-proofing.

As for a fix, I'm going to suggest that we implement a simple solution of filtering against alpha characters.  

Thanks,
Mark

Comment 2

[isabelrios]

(In reply to Mark Shiao from comment #1)
> Hi Isabel,
> 
> I agree this is not an ideal user experience, however since it is ux related
> I would like to get UX's opinion before proceeding.  

Hi Mark, 
Thanks. I cced also Ayman (UX) who was aware of it and gave me info to file the bug.  

>For comparison
> purposes, I've tested on my iphone and it provides the same experience.  You
> are able to create contacts from an invalid number.  I guess it's a question
> of how far we want to extend our dummy-proofing.
>
> As for a fix, I'm going to suggest that we implement a simple solution of
> filtering against alpha characters.  
OK, thanks

Comment 3

[Stephany Wilkes]

Reassigning to Ayman.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Practically a new feature for a future release to be able to detect the invalid number, this is not a blocker for v1.1.

Comment 5

[Rick Waldron [:rwaldron]]

How do you propose we define a "valid"? 


Also, bug 888306 is essentially a duplicate of this bug.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Not clear why this is being nominated with [leo-triage] flag, I will send an email out to clarify the intention of that flag, but in the meantime there is no way we can do anything here for v1.1 and I don't have the engineering skills to address the question in comment 5.  If someone wants to propose ideas here for a new feature in 'valid' detection please go ahead otherwise close this WONTFIX or INVALID (as suggested in bug 888306)

Comment 7

[Mark Shiao]

Un-assinging myself since this looks like it'll require more specing from the UX team.  

Thanks,
Mark

Comment 8

[ayman maat :maat]

this bug is closely related to:
https://bugzilla.mozilla.org/show_bug.cgi?id=823392

Comment 9

[ayman maat :maat]

i would like to discuss this bug at the oslo work week along with 823392 so marking whiteboard  [osloww]

Comment 10

[Julien Wajsberg [:julienw]]

Hey Isabel,

do you consider this is fixed after the work in bug 920546?

Comment 11

[isabelrios]

Attachment: Not possible to send a message to xxx.png

Comment 12

[isabelrios]

Hi Julien,

I would say so, but I prefer to have the confirmation from UX also since I filed this bug after checking it with Ayman, so ni? Ayman

Curredntly what happens is that an invalid number made of an string, like in the example in comment 0: 'xxx' is not considered a valid number. It is not possible to send the message and therefore it is not possible to tap on the header of a message containing 'xxx' in the header so, the options to call, send message or create as a new contact are not shown. 
Plese see screenshot attached.

Comment 13

[ayman maat :maat]

(In reply to Isabel Rios [:isabel_rios] from comment #12)
> Hi Julien,
> 
> I would say so, but I prefer to have the confirmation from UX also since I
> filed this bug after checking it with Ayman, so ni? Ayman
> 
> Curredntly what happens is that an invalid number made of an string, like in
> the example in comment 0: 'xxx' is not considered a valid number. It is not
> possible to send the message and therefore it is not possible to tap on the
> header of a message containing 'xxx' in the header so, the options to call,
> send message or create as a new contact are not shown. 
> Plese see screenshot attached.

Hey Isabel, Julien 
Yep i would say we could consider this fixed now. 
Good work :)

Comment 14

[Julien Wajsberg [:julienw]]

Closing this as INVALID then :)

Yeay!

Comment 15

[ayman maat :maat]

YAY :)