888267 - Expose Spdy version in Networking Dashboard

Status: RESOLVED DUPLICATE of bug 888583

(Core :: Networking, defect)

Description

[Robert Bindar]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130512193848

Steps to reproduce:

If a connexion uses spdy, now the version of it will be accessible in Dashboard.cpp

Comment 1

[Robert Bindar]

Attachment: Expose the spdy version in Dashboard.cpp

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 768925 [details] [diff] [review]
Expose the spdy version in Dashboard.cpp

Review of attachment 768925 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/nsHttpConnectionMgr.cpp
@@ +3322,5 @@
>      for (uint32_t i = 0; i < ent->mIdleConns.Length(); i++) {
>          HttpConnInfo info;
>          info.ttl = ent->mIdleConns[i]->TimeToLive();
>          info.rtt = ent->mIdleConns[i]->Rtt();
> +        info.spdyVersion = ent->mIdleConns[i]->GetSpdyVersion();

spdy connections are never in the idleconns array

can you make this so it reports http/1 version numbers too as we talked about on irc?

Comment 3

[Robert Bindar]

Attachment: Expose the spdy version in about:networking

Comment 4

[Robert Bindar]

:mcmanus i'm working on that, thanks.

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 769324 [details] [diff] [review]
Expose the spdy version in about:networking

Review of attachment 769324 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good but you should try to have one field for both spdy and http as per Patrick's comment in Bug 888583.

::: dom/webidl/NetDashboard.webidl
@@ +16,5 @@
>  
>  dictionary HttpConnInfoDict {
>  	sequence<unsigned long> rtt;
>  	sequence<unsigned long> ttl;
> +  sequence<octet> spdyVersion;

Try to keep the same indentation. It's best that you change it for the other 2 fields.