Closed Bug 888323 Opened 7 years ago Closed 7 years ago

XPCOM interface headers shouldn't include prtime.h everywhere

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: emk, Assigned: emk)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Most interface headers include nsrootidl.idl, which includes prtime.h, which will end up with including prtypes.h.
Green on try:
https://tbpl.mozilla.org/?tree=Try&rev=57fc813730e2
Attachment #768979 - Flags: review?(ehsan)
Attachment #768979 - Attachment is patch: true
Attachment #768979 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d155557b651c
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Flags: in-testsuite-
This caused bustage on M-i OS X 10.6 opt "Bg" builds:
  https://tbpl.mozilla.org/php/getParsedLog.php?id=24840393&tree=Mozilla-Inbound
/builds/slave/m-in-osx64_g-00000000000000000/build/dom/system/mac/CoreLocationLocationProvider.mm:86:23: error: use of undeclared identifier 'PR_Now'

...as well as OS X 10.7 opt:
https://tbpl.mozilla.org/php/getParsedLog.php?id=24840228&tree=Mozilla-Inbound
../../../../../dom/system/mac/CoreLocationLocationProvider.mm:86:23: error: use of undeclared identifier 'PR_Now'

So RyanVM backed it out:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/1e575c695425
It looks like that file, CoreLocationLocationProvider.mm, was just added on inbound yesterday (in bug 874587), which explains why Comment 0's Try run didn't hit this bustage.
Relanded with a fix for CoreLocationLocationProvider.
https://hg.mozilla.org/integration/mozilla-inbound/rev/30b2b15e03dc
https://hg.mozilla.org/mozilla-central/rev/30b2b15e03dc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.