888323 - XPCOM interface headers shouldn't include prtime.h everywhere

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

Most interface headers include nsrootidl.idl, which includes prtime.h, which will end up with including prtypes.h.
Green on try:
https://tbpl.mozilla.org/?tree=Try&rev=57fc813730e2

Comment 1

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d155557b651c

Comment 2

[Daniel Holbert [:dholbert]]

This caused bustage on M-i OS X 10.6 opt "Bg" builds:
  https://tbpl.mozilla.org/php/getParsedLog.php?id=24840393&tree=Mozilla-Inbound
/builds/slave/m-in-osx64_g-00000000000000000/build/dom/system/mac/CoreLocationLocationProvider.mm:86:23: error: use of undeclared identifier 'PR_Now'

...as well as OS X 10.7 opt:
https://tbpl.mozilla.org/php/getParsedLog.php?id=24840228&tree=Mozilla-Inbound
../../../../../dom/system/mac/CoreLocationLocationProvider.mm:86:23: error: use of undeclared identifier 'PR_Now'

So RyanVM backed it out:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/1e575c695425

Comment 3

[Daniel Holbert [:dholbert]]

It looks like that file, CoreLocationLocationProvider.mm, was just added on inbound yesterday (in bug 874587), which explains why Comment 0's Try run didn't hit this bustage.

Comment 4

[Masatoshi Kimura [:emk]]

https://tbpl.mozilla.org/?tree=Try&rev=c052a1c0a8d7

Comment 5

[Masatoshi Kimura [:emk]]

Relanded with a fix for CoreLocationLocationProvider.
https://hg.mozilla.org/integration/mozilla-inbound/rev/30b2b15e03dc

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/30b2b15e03dc