Closed Bug 888354 Opened 12 years ago Closed 12 years ago

Fix faulty `verifyResponse()` code

Categories

(Webmaker Graveyard :: Login, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sedge, Assigned: sedge)

References

Details

Attachments

(1 file)

This is an emergency patch to correct faulty code from bug 869592.
Status: NEW → ASSIGNED
QA Contact: kieran.sedgwick
Assignee: nobody → kieran.sedgwick
QA Contact: kieran.sedgwick
Comment on attachment 769042 [details] [review] https://github.com/mozilla/login.webmaker.org/pull/119 In your patch if I signout on the account page, login in another site (Tried with Popcorn Maker) and come back to the account page, I'm not auto signed in with this patch for some reason I'm finding. Maybe something is up with my local environment.
Attachment #769042 - Flags: review?(schranz.m) → review-
Commit pushed to master at https://github.com/mozilla/login.webmaker.org https://github.com/mozilla/login.webmaker.org/commit/81567aee6544900eba891dd8cb9ee5af84d76a70 Merge pull request #119 from ksedge/bug888354 [bug 8883354] Fixed verfiyResponse() logic
Tested on staging, fix succeeded
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: