Closed Bug 888360 Opened 11 years ago Closed 11 years ago

[cleanup] Remove install.js

Categories

(Marketplace Graveyard :: Consumer Pages, defect)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013-07-18

People

(Reporter: basta, Assigned: basta)

References

Details

(Keywords: perf, Whiteboard: [qa-])

install.js is a remnant of a darker time. It abstracts abstractions of mozApps and mozPay, which is silly and weird. It is a cesspool of obscure and convoluted bugs and a rat's nest of custom events. We should merge its code into buttons.js and use deferreds for the whole install/pay pipeline, use lexical scope rather than passing app objects through events, and refer to buttons via "this" rather than selecting them with [data-manifest="..."]. This is going to save a lot of bytes and eliminate a lot of really frustrating (and difficult to reproduce) buttons-related bugs.
Blocks: 838848
https://github.com/mozilla/fireplace/commit/97de8bf74e409a61478ed71d7110c40b0ba5c5e4
Assignee: nobody → mattbasta
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2013-07-18
Can you please add some STRs or mark the bug as [qa-] ?
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.