Closed
Bug 888378
Opened 12 years ago
Closed 12 years ago
mozdevice dmadb's reboot function is broken
Categories
(Testing :: Mozbase, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file)
|
870 bytes,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
Yes it is, we should fix it.
|
Assignee | |
Comment 1•12 years ago
|
||
As far as I can tell, if you actually call "adb reboot" and wait, it won't return until the device is actually rebooting. So I think we can dispense with the timer thing entirely (never mind that it was an infinite loop before)
Attachment #769040 -
Flags: review?(ahalberstadt)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 769040 [details] [diff] [review]
Fix dmADB's reboot
Review of attachment 769040 [details] [diff] [review]:
-----------------------------------------------------------------
I think I'd prefer wait=True by default, otherwise people will not know about this feature and add sleeps. But apparently dmSUT does wait=False by default too, so we can leave as is or do a follow-up
Attachment #769040 -
Flags: review?(ahalberstadt) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
I filed bug 888432 to deal with the inconsistency and wait problems.
|
|
Assignee | |
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•