888381 - java.lang.NullPointerException: at org.mozilla.gecko.BrowserToolbar.closeOptionsMenu(BrowserToolbar.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It has been several times by four users in 25.0a1/20130628. The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3b955f306226&tochange=8e3a124c9c1a
It's likely a regression from bug 886528.

Here is a crash report: bp-2fbaa6ad-c4a1-4a40-b71b-86df32130628.

java.lang.NullPointerException
	at org.mozilla.gecko.BrowserToolbar.closeOptionsMenu(BrowserToolbar.java:1169)
	at org.mozilla.gecko.BrowserApp.closeOptionsMenu(BrowserApp.java:1577)
	at org.mozilla.gecko.GeckoApp.closeMenu(GeckoApp.java:370)
	at org.mozilla.gecko.menu.GeckoMenu.close(GeckoMenu.java:233)
	at org.mozilla.gecko.menu.GeckoMenu.handleMenuItemClick(GeckoMenu.java:411)
	at org.mozilla.gecko.menu.GeckoMenu.access$000(GeckoMenu.java:31)
	at org.mozilla.gecko.menu.GeckoMenu$1.onClick(GeckoMenu.java:169)
	at android.view.View.performClick(View.java:4211)
	at android.view.View$PerformClick.run(View.java:17362)
	at android.os.Handler.handleCallback(Handler.java:725)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:5227)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:795)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:562)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?product=FennecAndroid&signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.BrowserToolbar.closeOptionsMenu%28BrowserToolbar.java%29

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

I believe that's the line of code as nothing else could cause an NPE inside that method.

Comment 2

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0436736b97ce

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0436736b97ce