Closed Bug 888389 Opened 7 years ago Closed 7 years ago

Cycle collect PowerManager

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: mccr8, Assigned: mccr8)

Details

(Whiteboard: [MemShrink:P3])

Attachments

(1 file, 1 obsolete file)

nsIDOMMozWakeLockListener can be implemented by JS, so PowerManager should be cycle collected, and Traversed in Navigator.  We could potentially get a cycle from Navigator to PowerManager to a JS wake lock listener back to Navigator.
Attached patch simple, untested (obsolete) — Splinter Review
Whiteboard: [MemShrink] → [MemShrink:P3]
Attachment #769107 - Attachment is obsolete: true
My try push failed to run due to bug 893574, but at least it compiles...
https://tbpl.mozilla.org/?tree=Try&rev=d5aa21b71cec
Comment on attachment 775261 [details] [diff] [review]
minor unbitrotting

try failure was due to infra failure.  retrigger looks good.
Attachment #775261 - Flags: review?(bugs)
Attachment #775261 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/e489921e3808
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.