remove dead bits and parameters in the frontend

RESOLVED FIXED in mozilla25

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Assignee)

Description

5 years ago
Specifically:
 - PND_BLOCKCHILD / InBlockBool
 - the 'strict' arg in some places
 - the function name in some places
 - startOffset
(Assignee)

Comment 1

5 years ago
Created attachment 769135 [details] [diff] [review]
rm PND_BLOCKCHILD
Attachment #769135 - Flags: review?(bhackett1024)
(Assignee)

Comment 2

5 years ago
Created attachment 769136 [details] [diff] [review]
rm 'strict' argument in some places
Attachment #769136 - Flags: review?(bhackett1024)
(Assignee)

Comment 3

5 years ago
Created attachment 769138 [details] [diff] [review]
rm dead assignment to 'body'
Attachment #769138 - Flags: review?(bhackett1024)
(Assignee)

Comment 4

5 years ago
Created attachment 769143 [details] [diff] [review]
rm funName argument

The one interesting thing in this patch is that there is one place where there is the decision between creating a RootedPropertyName just to pass a HandlePropertyName to a function that just does a few comparisons, so I opted to pass the PropertyName* but I could switch if you felt strongly.
Attachment #769143 - Flags: review?(bhackett1024)
(Assignee)

Comment 5

5 years ago
Created attachment 769144 [details] [diff] [review]
rm startOffset argument
Attachment #769144 - Flags: review?(bhackett1024)
Attachment #769135 - Flags: review?(bhackett1024) → review+
Attachment #769136 - Flags: review?(bhackett1024) → review+
Comment on attachment 769138 [details] [diff] [review]
rm dead assignment to 'body'

Review of attachment 769138 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/frontend/Parser.cpp
@@ -1909,5 @@
>  
>      // If the outer scope is strict, immediately parse the function in strict
>      // mode. Otherwise, we parse it normally. If we see a "use strict"
>      // directive, we backup and reparse it as strict.
> -    handler.setFunctionBody(pn, null());

Maybe a brief comment on the call to this function that still exists below?
Attachment #769138 - Flags: review?(bhackett1024) → review+
Attachment #769143 - Flags: review?(bhackett1024) → review+
Attachment #769144 - Flags: review?(bhackett1024) → review+
You need to log in before you can comment on or make changes to this bug.