888469 - remove dead bits and parameters in the frontend

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Specifically:
 - PND_BLOCKCHILD / InBlockBool
 - the 'strict' arg in some places
 - the function name in some places
 - startOffset

Comment 1

[Luke Wagner [:luke]]

Attachment: rm PND_BLOCKCHILD

Comment 2

[Luke Wagner [:luke]]

Attachment: rm 'strict' argument in some places

Comment 3

[Luke Wagner [:luke]]

Attachment: rm dead assignment to 'body'

Comment 4

[Luke Wagner [:luke]]

Attachment: rm funName argument

The one interesting thing in this patch is that there is one place where there is the decision between creating a RootedPropertyName just to pass a HandlePropertyName to a function that just does a few comparisons, so I opted to pass the PropertyName* but I could switch if you felt strongly.

Comment 5

[Luke Wagner [:luke]]

Attachment: rm startOffset argument

Comment 6

[Brian Hackett [Laid off!]]

Comment on attachment 769138 [details] [diff] [review]
rm dead assignment to 'body'

Review of attachment 769138 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/frontend/Parser.cpp
@@ -1909,5 @@
>  
>      // If the outer scope is strict, immediately parse the function in strict
>      // mode. Otherwise, we parse it normally. If we see a "use strict"
>      // directive, we backup and reparse it as strict.
> -    handler.setFunctionBody(pn, null());

Maybe a brief comment on the call to this function that still exists below?

Comment 7

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16dbea1e669a
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba4f02ad34b2
https://hg.mozilla.org/integration/mozilla-inbound/rev/81286c5eadfb
https://hg.mozilla.org/integration/mozilla-inbound/rev/84c314017f01
https://hg.mozilla.org/integration/mozilla-inbound/rev/12fa46ef0a3e

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/16dbea1e669a
https://hg.mozilla.org/mozilla-central/rev/ba4f02ad34b2
https://hg.mozilla.org/mozilla-central/rev/81286c5eadfb
https://hg.mozilla.org/mozilla-central/rev/84c314017f01
https://hg.mozilla.org/mozilla-central/rev/12fa46ef0a3e