888492 - Use the content window rather than tabbrowser for load notifications

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Dave Camp (:dcamp)]

Attachment: v1

Needed this for android to work.

Comment 1

[Dave Camp (:dcamp)]

Comment on attachment 769182 [details] [diff] [review]
v1

This patch breaks things that it can't break.  Marking obsolete until I figure out why.

Comment 2

[Dave Camp (:dcamp)]

Attachment: webprogress.diff

This is much better.

Comment 3

[Joe Walker [:jwalker]]

Comment on attachment 795500 [details] [diff] [review]
webprogress.diff

Review of attachment 795500 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/inspector.js
@@ +700,5 @@
>  var ProgressListener = Class({
>    extends: Unknown,
>    interfaces: ["nsIWebProgressListener", "nsISupportsWeakReference"],
>  
> +  initialize: function(tabActor) {

I'm trying to work out if this helps anything - we widen the scope of things we can break without apparent reason.

Comment 4

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/66674eef2042

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/66674eef2042

Comment 6

[Dave Camp (:dcamp)]

Comment on attachment 795500 [details] [diff] [review]
webprogress.diff

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Remote inspector
User impact if declined: This is related to bug 897194.
Testing completed (on m-c, etc.): been on m-c for a little while
Risk to taking this patch (and alternatives if risky): It affects devtools during navigation, but should be more help than harm.
String or IDL/UUID changes made by this patch: None.

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 795500 [details] [diff] [review]
webprogress.diff

Not worth tracking for release, but agreed on uplift.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1874fd8b5788

Comment 9

[u279076]

Assuming no verification needed here. Please add the verifyme keyword and remove the [qa-] whiteboard tag to request verification.