888516 - [traceback] /api/v1/account/newsletter/: KeyError 'email' when submitting an empty email address to the Newsletter

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Load https://marketplace-dev.allizom.org/ and log in
2. In the Newsletter Sign-up area, submit an empty email address

Actual:

/api/v1/account/newsletter/: KeyError 'email'
['  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20130628145217-d17dd9a72a/venv/lib/python2.6/site-packages/tastypie/resources.py", line 192, in wrapper\n    response = callback(request, *args, **kwargs)\n', '  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20130628145217-d17dd9a72a/venv/lib/python2.6/site-

Stacktrace (most recent call last):

  File "tastypie/resources.py", line 192, in wrapper
    response = callback(request, *args, **kwargs)
  File "tastypie/resources.py", line 397, in dispatch_list
    return self.dispatch('list', request, **kwargs)
  File "mkt/api/base.py", line 94, in dispatch
    .dispatch(request_type, request, **kwargs))
  File "tastypie/resources.py", line 427, in dispatch
    response = method(request, **kwargs)
  File "mkt/account/api.py", line 243, in post_list
    basket.subscribe(data['email'], 'marketplace',

Sentry link: http://sentry.dmz.phx1.mozilla.com/addons/marketplace-dev/group/15506/

Comment 1

[Davor Spasovski [:spasovski]]

After https://github.com/mozilla/fireplace/commit/2e0448e this will be tougher (but not impossible - client side checking only). We should have some API level email validation.

Comment 2

[Allen Short [:ashort]]

https://github.com/mozilla/zamboni/commit/85f455b

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I'm prohibited from entering a null value.