Closed Bug 888562 Opened 7 years ago Closed 6 years ago

avoid allocating MemoryImage surfaces over and over

Categories

(Core :: Graphics: Layers, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED WONTFIX

People

(Reporter: gal, Unassigned)

References

(Blocks 1 open bug, )

Details

Attachments

(2 files)

Cache surfaces during allocation spikes to avoid allocating and memset-ing the surfaces constantly.
Blocks: 885655
No longer depends on: 885655, 888530
Attached patch patchSplinter Review
Attachment #769304 - Flags: review?(matt.woodrow)
Attachment #769304 - Flags: review?(matt.woodrow) → review+
Attachment #772877 - Flags: review?(jmuizelaar)
Comment on attachment 772877 [details] [diff] [review]
Recycle memory surface

I didn't review the new code very thoroughly as I assume that matt has already reviewed that.
Attachment #772877 - Flags: review?(jmuizelaar) → review+
This also caused:
 <Regression> Mozilla-Inbound - Tp5 Optimized (Main RSS) - MacOSX 10.7 - 15.6% 
which went away when KWierso backed it out.

(dev-tree-management bot incorrectly blamed the previous push, but if you look at the graph it's abundantly clear that it started on this cset's push.)

More info here:
https://groups.google.com/forum/#!topic/mozilla.dev.tree-management/BwXpmvAQzng
Well, my backout had that same conformance test failure that I backed the push out for: https://tbpl.mozilla.org/php/getParsedLog.php?id=25106631&tree=Mozilla-Inbound

Though the failure didn't show up until the following push, so maybe this won't be fixed immediately by the backout, either?
Wes, Jeff, can you please revisit this bug? It's one of the last OMTC issues on Mac.
… I actually should have meant Andreas. Sorry!
Assignee: nobody → gal
Milan can you find an assignee?
Assignee: gal → milan
With the demise of MemoryImage with bug 991028, this is not relevant anymore, right?
Assignee: milan → nobody
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.