Closed
Bug 888565
Opened 11 years ago
Closed 11 years ago
Localize /account page on login server
Categories
(Webmaker Graveyard :: Login, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alicoding, Assigned: alicoding)
References
Details
(Whiteboard: s=2013w29 p=1)
Attachments
(1 file)
Start localize /account page using the i18n abide
Assignee | ||
Comment 1•11 years ago
|
||
I have to change the structure of the folder a bit to get everything work the way we wanted. -------- The first big change was converting from EJS to nunjucks and that one I filed a bug and got it landed, and the reason I have to change it to nunjucks because the i18n-abide not fully compatible with the EJS and having problem with the global variable. Secondly, I have to renamed the folder of the javascripts file where it used to be 'js' now I've changed it to 'javascript' to avoid the problem of the URL stripping. Lastly, I have also extract the string off the requirejs. This one is a bit weird because the text works but not for other language except English. What I mean is that if I use `{{ gettext('iloveyou') }}` I would still see `I love you` but only in English.
Attachment #769316 -
Flags: review?(david.humphrey)
Assignee | ||
Comment 2•11 years ago
|
||
I thought about it and found a better solution: Now I can reverse back to all the folder names that have js/css/img/ext I added the regex in i18n-abide to ignore those, and now this will work perfectly.
Updated•11 years ago
|
Assignee: nobody → ali
Comment 3•11 years ago
|
||
Is there a Meta ticket existing on completing the localization module you are using? If so, this and the other tickets you have filed on localizing specific parts of apps should be marked as blocked on that until it has been reviewed and is good to go. If not, please file it and do the above :)
Status: NEW → ASSIGNED
Comment 4•11 years ago
|
||
Comment on attachment 769316 [details] [review] https://github.com/mozilla/login.webmaker.org/pull/121 This is going to need to be updated to use the new i18n-abide stuff, once that lands. Cancelling review until then.
Attachment #769316 -
Flags: review?(david.humphrey)
Assignee | ||
Updated•11 years ago
|
Attachment #769316 -
Flags: review?(david.humphrey)
Comment 5•11 years ago
|
||
Comment on attachment 769316 [details] [review] https://github.com/mozilla/login.webmaker.org/pull/121 Looks OK, just some small things in the PR. I'm flagging Dale for a front-end review on this. Please don't land this until we chat with Jon about turning things on with l10n, which this will do.
Attachment #769316 -
Flags: review?(david.humphrey)
Attachment #769316 -
Flags: review?(dale)
Attachment #769316 -
Flags: review+
Comment 6•11 years ago
|
||
Comment on attachment 769316 [details] [review] https://github.com/mozilla/login.webmaker.org/pull/121 Tested locally, works. Looks good, just squash commits into one, wait for Travis to go green and feel free to land!
Attachment #769316 -
Flags: review?(dale) → review+
Assignee | ||
Updated•11 years ago
|
Whiteboard: wb.localization
Assignee | ||
Updated•11 years ago
|
Whiteboard: wb.localization → s=2013w29 p=1
Comment 7•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/login.webmaker.org https://github.com/mozilla/login.webmaker.org/commit/7f20622924faf42ba48931f62d0086079d96eaa4 Bug 888565 - Localized Login page on /account route
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•