Closed Bug 888574 Opened 7 years ago Closed 7 years ago

Remove TAR_CREATE_FLAGS_QUIET, make TAR_CREATE_FLAGS quiet by default

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
Removes 57 lines of output on a no-op build; this leaves ~25 non-NSS lines.
Attachment #769331 - Flags: review?(gps)
Comment on attachment 769331 [details] [diff] [review]
Patch v1

Review of attachment 769331 [details] [diff] [review]:
-----------------------------------------------------------------

I can't help but think that somewhere someone is utilizing the printed list of files and defaulting to non-verbose will upset them or make their workflow harder. That being said, I'm inclined to just land this then address any complaints that arise. This is certainly easy enough to back out if it causes anyone hurt.

The changes in this patch look good, but I'd like additional sign-off from someone on the automation side of the fence.
Attachment #769331 - Flags: review?(ted)
Attachment #769331 - Flags: review?(gps)
Attachment #769331 - Flags: review+
Comment on attachment 769331 [details] [diff] [review]
Patch v1

Review of attachment 769331 [details] [diff] [review]:
-----------------------------------------------------------------

A brief survey of mxr shows that we only ever seem to use TAR_CREATE_FLAGS when running tar with - as the output filename, which means this spew is all going to stderr anyway, so someone would have to be jumping through great hoops to do anything with it. I'm not aware of anywhere that we actually need the output.
Attachment #769331 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/82df23e7392f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.