Micro-optimization of js::ToInteger

RESOLVED FIXED in mozilla25

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: till, Assigned: till)

Tracking

unspecified
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 769361 [details] [diff] [review]
Micro-optimization of js::ToInteger
(Assignee)

Comment 2

6 years ago
Created attachment 769362 [details]
micro-benchmark
(Assignee)

Comment 3

6 years ago
Created attachment 769363 [details]
micro-benchmark, unrolled
Attachment #769362 - Attachment is obsolete: true
(Assignee)

Comment 4

6 years ago
Comment on attachment 769361 [details] [diff] [review]
Micro-optimization of js::ToInteger

Stumbled upon this.

The attached micro-benchmark gets a speedup of ~9%. While I doubt that that makes a difference in any benchmarks we care about, simplifying code and getting rid of two branches can't be wrong. Right?
Attachment #769361 - Flags: review?(jwalden+bmo)
Attachment #769361 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/ea3f2bc8bc1e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.