Closed
Bug 888643
Opened 11 years ago
Closed 11 years ago
Move CPP_UNIT_TESTS to moz.build
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla25
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
5.34 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
22.92 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
1.26 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #769396 -
Flags: review?(gps)
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #769397 -
Flags: review?(gps)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #769398 -
Flags: review?(gps)
Updated•11 years ago
|
Attachment #769396 -
Flags: review?(gps) → review+
Comment 3•11 years ago
|
||
Comment on attachment 769397 [details] [diff] [review] Part b: moves Review of attachment 769397 [details] [diff] [review]: ----------------------------------------------------------------- ::: media/webrtc/signaling/test/moz.build @@ +5,5 @@ > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > MODULE = 'test_signaling' > > +if CONFIG['OS_TARGET'] != 'WINNT' and CONFIG['MOZ_WIDGET_TOOLKIT'] != 'gonk' The first time I saw this conditional was OK. Now, I'm thinking we should have a dedicated configure-defined flag for this feature. But, that's for another bug. ::: xpcom/tests/windows/moz.build @@ +8,5 @@ > > +CPP_UNIT_TESTS += [ > + 'TestCOM.cpp', > +] > + First, why did you lose the comment? Second, this underscores an important trait of static definitions (or manifests): you can easily audit filesystem content against the static lists and look for discrepancies. I fear that every universally disabled test is a land mine waiting to explode due to assumptions that it's actually running.
Attachment #769397 -
Flags: review?(gps) → review+
Updated•11 years ago
|
Attachment #769398 -
Flags: review?(gps) → review+
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8a0c0ccab65f https://hg.mozilla.org/mozilla-central/rev/321a9432686d https://hg.mozilla.org/mozilla-central/rev/60dac6b9c68a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•