Update Yarr yet again

RESOLVED FIXED in mozilla25

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: till, Assigned: till)

Tracking

unspecified
mozilla25
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Assignee)

Description

5 years ago
Manual update of Yarr. There weren't actually that many changes, so I went through them by hand.

Really, there's only two noteworthy changes:
- less allocation through https://bugs.webkit.org/show_bug.cgi?id=114409
- updated character classes, which includes turning the BOM into whitespace

I have a wip patch for applying http://webkit.org/b/109218, but punted on finishing that for now as it requires changes to our JS::Vector shim. I'll attach that separately.

To make reviewing easier, I'll also attach three JSCore diffs:
- one for the entire range
- one for everyting up to, but not including http://webkit.org/b/109218
- one for everything after http://webkit.org/b/109218
(Assignee)

Comment 1

5 years ago
Created attachment 769430 [details] [diff] [review]
Update Yarr yet again
Attachment #769430 - Flags: review?(sstangl)
(Assignee)

Updated

5 years ago
Blocks: 888630
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 769431 [details] [diff] [review]
Diff of the whole revision range
(Assignee)

Comment 3

5 years ago
Created attachment 769432 [details] [diff] [review]
Diff of everyting before the OwnPtr stuff
(Assignee)

Comment 4

5 years ago
Created attachment 769433 [details] [diff] [review]
Diff of everyting after the OwnPtr stuff
(Assignee)

Comment 5

5 years ago
Created attachment 769434 [details] [diff] [review]
Apply OwnPtr-related upstream changes to Yarr. wip
Comment on attachment 769430 [details] [diff] [review]
Update Yarr yet again

Review of attachment 769430 [details] [diff] [review]:
-----------------------------------------------------------------

Looks innocuous to me.
Attachment #769430 - Flags: review?(sstangl) → review+
https://hg.mozilla.org/mozilla-central/rev/27d2bbc32667
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.