Closed
Bug 888685
Opened 9 years ago
Closed 2 years ago
SVG helper classes don't need to inherit nsISupports
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
81 Branch
Tracking | Status | |
---|---|---|
firefox81 | --- | fixed |
People
(Reporter: dzbarsky, Assigned: dzbarsky)
Details
Attachments
(11 files)
3.67 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
3.65 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
2.48 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
2.59 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
3.63 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
2.74 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
2.56 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
2.50 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
2.58 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
2.55 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
47 bytes,
text/x-phabricator-request
|
Details | Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #769446 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #769447 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #769448 -
Flags: review?(Ms2ger)
Updated•9 years ago
|
Attachment #769443 -
Flags: review?(Ms2ger) → review+
Updated•9 years ago
|
Attachment #769446 -
Flags: review?(Ms2ger) → review+
Updated•9 years ago
|
Attachment #769447 -
Flags: review?(Ms2ger) → review+
Updated•9 years ago
|
Attachment #769448 -
Flags: review?(Ms2ger) → review+
Assignee | ||
Comment 5•9 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/d159664c149b remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/16cbc14922e9 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/7cc8adba8e91 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/28c5562d46c4
Whiteboard: [leave open]
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d159664c149b https://hg.mozilla.org/mozilla-central/rev/16cbc14922e9 https://hg.mozilla.org/mozilla-central/rev/7cc8adba8e91 https://hg.mozilla.org/mozilla-central/rev/28c5562d46c4
Assignee | ||
Comment 7•9 years ago
|
||
Assignee | ||
Comment 8•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #777465 -
Flags: review?(Ms2ger)
Assignee | ||
Updated•9 years ago
|
Attachment #777467 -
Flags: review?(Ms2ger)
Updated•9 years ago
|
Attachment #777465 -
Flags: review?(Ms2ger) → review+
Updated•9 years ago
|
Attachment #777467 -
Flags: review?(Ms2ger) → review+
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d673673d7ee2 https://hg.mozilla.org/integration/mozilla-inbound/rev/93937caf5d57
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d673673d7ee2 https://hg.mozilla.org/mozilla-central/rev/93937caf5d57
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #821594 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 12•9 years ago
|
||
Attachment #821596 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 13•9 years ago
|
||
Attachment #821598 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 14•9 years ago
|
||
Attachment #821599 -
Flags: review?(Ms2ger)
Comment 15•9 years ago
|
||
Comment on attachment 821594 [details] [diff] [review] SVGStringList Don't have time for these, sorry.
Attachment #821594 -
Flags: review?(Ms2ger)
Updated•9 years ago
|
Attachment #821596 -
Flags: review?(Ms2ger)
Updated•9 years ago
|
Attachment #821598 -
Flags: review?(Ms2ger)
Updated•9 years ago
|
Attachment #821599 -
Flags: review?(Ms2ger)
Assignee | ||
Updated•9 years ago
|
Attachment #821594 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•9 years ago
|
Attachment #821596 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•9 years ago
|
Attachment #821598 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•9 years ago
|
Attachment #821599 -
Flags: review?(bzbarsky)
![]() |
||
Comment 16•9 years ago
|
||
Comment on attachment 821594 [details] [diff] [review] SVGStringList r=me
Attachment #821594 -
Flags: review?(bzbarsky) → review+
![]() |
||
Comment 17•9 years ago
|
||
Comment on attachment 821596 [details] [diff] [review] SVGTransformList r=me
Attachment #821596 -
Flags: review?(bzbarsky) → review+
![]() |
||
Comment 18•9 years ago
|
||
Comment on attachment 821598 [details] [diff] [review] SVGPathSegList r=me
Attachment #821598 -
Flags: review?(bzbarsky) → review+
![]() |
||
Comment 19•9 years ago
|
||
Comment on attachment 821599 [details] [diff] [review] SVGPointList r=me
Attachment #821599 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 20•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/885c09371fe5 https://hg.mozilla.org/integration/mozilla-inbound/rev/6183a79d8d52 https://hg.mozilla.org/integration/mozilla-inbound/rev/a8693095d80c https://hg.mozilla.org/integration/mozilla-inbound/rev/ca927541e644
Whiteboard: [leave open]
Comment 21•9 years ago
|
||
This doesn't build on any platform: Unified_cpp_content_canvas_src1.o In file included from SVGMatrixBinding.cpp:6:0, from UnifiedBindings24.cpp:2: ../../dist/include/mozilla/dom/BindingUtils.h: In instantiation of 'struct mozilla::dom::WantsQueryInterface<mozilla::DOMSVGPathSegList>': SVGPathSegListBinding.cpp:451:59: required from here ../../dist/include/mozilla/dom/BindingUtils.h:1427:3: error: static assertion failed: QueryInterface can't work without an nsISupports. In file included from UnifiedBindings24.cpp:62:0: SVGPathSegListBinding.cpp:563:1: error: static assertion failed: We don't support non-nsISupports native classes for proxy-based bindings yet In file included from SVGMatrixBinding.cpp:6:0, from UnifiedBindings24.cpp:2: ../../dist/include/mozilla/dom/BindingUtils.h: In instantiation of 'struct mozilla::dom::WantsQueryInterface<mozilla::DOMSVGPointList>': SVGPointListBinding.cpp:451:57: required from here ../../dist/include/mozilla/dom/BindingUtils.h:1427:3: error: static assertion failed: QueryInterface can't work without an nsISupports. In file included from UnifiedBindings24.cpp:98:0: SVGPointListBinding.cpp:563:1: error: static assertion failed: We don't support non-nsISupports native classes for proxy-based bindings yet
![]() |
||
Comment 22•9 years ago
|
||
Backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/510848e67250
Comment 23•9 years ago
|
||
FWIW, at least two of the other classes changed by this set of patches have this same build problem.
Comment 24•2 years ago
|
||
Comment 25•2 years ago
|
||
Pushed by longsonr@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b12bf7594d80 Remove nsISupports from remaining SVG DOM classes r=mccr8
Comment 26•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox81:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•