888685 - SVG helper classes don't need to inherit nsISupports

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: SVGAnimatedBoolean

Comment 2

[David Zbarsky (:dzbarsky)]

Attachment: SVGAngle

Comment 3

[David Zbarsky (:dzbarsky)]

Attachment: SVGAnimatedAngle

Comment 4

[David Zbarsky (:dzbarsky)]

Attachment: SVGAnimatedLength

Comment 5

[David Zbarsky (:dzbarsky)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d159664c149b
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/16cbc14922e9
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/7cc8adba8e91
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/28c5562d46c4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d159664c149b
https://hg.mozilla.org/mozilla-central/rev/16cbc14922e9
https://hg.mozilla.org/mozilla-central/rev/7cc8adba8e91
https://hg.mozilla.org/mozilla-central/rev/28c5562d46c4

Comment 7

[David Zbarsky (:dzbarsky)]

Attachment: SVGAnimatedLengthList shouldn't inherit nsISupports r=Ms2ger

Comment 8

[David Zbarsky (:dzbarsky)]

Attachment: SVGAnimatedRect shouldn't inherit nsISupports r=Ms2ger

Comment 9

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d673673d7ee2
https://hg.mozilla.org/integration/mozilla-inbound/rev/93937caf5d57

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d673673d7ee2
https://hg.mozilla.org/mozilla-central/rev/93937caf5d57

Comment 11

[David Zbarsky (:dzbarsky)]

Attachment: SVGStringList

Comment 12

[David Zbarsky (:dzbarsky)]

Attachment: SVGTransformList

Comment 13

[David Zbarsky (:dzbarsky)]

Attachment: SVGPathSegList

Comment 14

[David Zbarsky (:dzbarsky)]

Attachment: SVGPointList

Comment 15

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 821594 [details] [diff] [review]
SVGStringList

Don't have time for these, sorry.

Comment 16

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 821594 [details] [diff] [review]
SVGStringList

r=me

Comment 17

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 821596 [details] [diff] [review]
SVGTransformList

r=me

Comment 18

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 821598 [details] [diff] [review]
SVGPathSegList

r=me

Comment 19

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 821599 [details] [diff] [review]
SVGPointList

r=me

Comment 20

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/885c09371fe5
https://hg.mozilla.org/integration/mozilla-inbound/rev/6183a79d8d52
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8693095d80c
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca927541e644

Comment 21

[Andrew McCreight [:mccr8]]

This doesn't build on any platform:

Unified_cpp_content_canvas_src1.o
In file included from SVGMatrixBinding.cpp:6:0,
                 from UnifiedBindings24.cpp:2:
../../dist/include/mozilla/dom/BindingUtils.h: In instantiation of 'struct mozilla::dom::WantsQueryInterface<mozilla::DOMSVGPathSegList>':
SVGPathSegListBinding.cpp:451:59:   required from here
../../dist/include/mozilla/dom/BindingUtils.h:1427:3: error: static assertion failed: QueryInterface can't work without an nsISupports.
In file included from UnifiedBindings24.cpp:62:0:
SVGPathSegListBinding.cpp:563:1: error: static assertion failed: We don't support non-nsISupports native classes for proxy-based bindings yet
In file included from SVGMatrixBinding.cpp:6:0,
                 from UnifiedBindings24.cpp:2:
../../dist/include/mozilla/dom/BindingUtils.h: In instantiation of 'struct mozilla::dom::WantsQueryInterface<mozilla::DOMSVGPointList>':
SVGPointListBinding.cpp:451:57:   required from here
../../dist/include/mozilla/dom/BindingUtils.h:1427:3: error: static assertion failed: QueryInterface can't work without an nsISupports.
In file included from UnifiedBindings24.cpp:98:0:
SVGPointListBinding.cpp:563:1: error: static assertion failed: We don't support non-nsISupports native classes for proxy-based bindings yet

Comment 22

[Nathan Froyd [:froydnj]]

Backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/510848e67250

Comment 23

[Andrew McCreight [:mccr8]]

FWIW, at least two of the other classes changed by this set of patches have this same build problem.

Comment 24

[Robert Longson [:longsonr]]

Attachment: Bug 888685 - Remove nsISupports from remaining SVG DOM classes

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b12bf7594d80
Remove nsISupports from remaining SVG DOM classes r=mccr8

Comment 26

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b12bf7594d80