Closed Bug 888685 Opened 8 years ago Closed 4 months ago

SVG helper classes don't need to inherit nsISupports

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Details

Attachments

(11 files)

No description provided.
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Attachment #769443 - Flags: review?(Ms2ger)
Attached patch SVGAngleSplinter Review
Attachment #769446 - Flags: review?(Ms2ger)
Attached patch SVGAnimatedAngleSplinter Review
Attachment #769447 - Flags: review?(Ms2ger)
Attachment #769448 - Flags: review?(Ms2ger)
Attachment #769443 - Flags: review?(Ms2ger) → review+
Attachment #769446 - Flags: review?(Ms2ger) → review+
Attachment #769447 - Flags: review?(Ms2ger) → review+
Attachment #769448 - Flags: review?(Ms2ger) → review+
Attachment #777465 - Flags: review?(Ms2ger)
Attachment #777467 - Flags: review?(Ms2ger)
Attachment #777465 - Flags: review?(Ms2ger) → review+
Attachment #777467 - Flags: review?(Ms2ger) → review+
Attached patch SVGStringListSplinter Review
Attachment #821594 - Flags: review?(Ms2ger)
Attached patch SVGTransformListSplinter Review
Attachment #821596 - Flags: review?(Ms2ger)
Attached patch SVGPathSegListSplinter Review
Attachment #821598 - Flags: review?(Ms2ger)
Attached patch SVGPointListSplinter Review
Attachment #821599 - Flags: review?(Ms2ger)
Comment on attachment 821594 [details] [diff] [review]
SVGStringList

Don't have time for these, sorry.
Attachment #821594 - Flags: review?(Ms2ger)
Attachment #821596 - Flags: review?(Ms2ger)
Attachment #821598 - Flags: review?(Ms2ger)
Attachment #821599 - Flags: review?(Ms2ger)
Attachment #821594 - Flags: review?(bzbarsky)
Attachment #821596 - Flags: review?(bzbarsky)
Attachment #821598 - Flags: review?(bzbarsky)
Attachment #821599 - Flags: review?(bzbarsky)
Comment on attachment 821594 [details] [diff] [review]
SVGStringList

r=me
Attachment #821594 - Flags: review?(bzbarsky) → review+
Comment on attachment 821596 [details] [diff] [review]
SVGTransformList

r=me
Attachment #821596 - Flags: review?(bzbarsky) → review+
Comment on attachment 821598 [details] [diff] [review]
SVGPathSegList

r=me
Attachment #821598 - Flags: review?(bzbarsky) → review+
Comment on attachment 821599 [details] [diff] [review]
SVGPointList

r=me
Attachment #821599 - Flags: review?(bzbarsky) → review+
This doesn't build on any platform:

Unified_cpp_content_canvas_src1.o
In file included from SVGMatrixBinding.cpp:6:0,
                 from UnifiedBindings24.cpp:2:
../../dist/include/mozilla/dom/BindingUtils.h: In instantiation of 'struct mozilla::dom::WantsQueryInterface<mozilla::DOMSVGPathSegList>':
SVGPathSegListBinding.cpp:451:59:   required from here
../../dist/include/mozilla/dom/BindingUtils.h:1427:3: error: static assertion failed: QueryInterface can't work without an nsISupports.
In file included from UnifiedBindings24.cpp:62:0:
SVGPathSegListBinding.cpp:563:1: error: static assertion failed: We don't support non-nsISupports native classes for proxy-based bindings yet
In file included from SVGMatrixBinding.cpp:6:0,
                 from UnifiedBindings24.cpp:2:
../../dist/include/mozilla/dom/BindingUtils.h: In instantiation of 'struct mozilla::dom::WantsQueryInterface<mozilla::DOMSVGPointList>':
SVGPointListBinding.cpp:451:57:   required from here
../../dist/include/mozilla/dom/BindingUtils.h:1427:3: error: static assertion failed: QueryInterface can't work without an nsISupports.
In file included from UnifiedBindings24.cpp:98:0:
SVGPointListBinding.cpp:563:1: error: static assertion failed: We don't support non-nsISupports native classes for proxy-based bindings yet
FWIW, at least two of the other classes changed by this set of patches have this same build problem.
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b12bf7594d80
Remove nsISupports from remaining SVG DOM classes r=mccr8
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.