Closed
Bug 888773
Opened 11 years ago
Closed 10 years ago
Sidebar followup: show/hide should take a window argument
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: evold)
References
Details
Attachments
(1 file)
Atm the show/hide methods take no arguments and show/hide on the most recent window (if it is not private), they should take window arguments.
|
Assignee | |
Updated•11 years ago
|
Depends on: sdk/ui/sidebar
|
|
Assignee | |
Updated•11 years ago
|
Blocks: sdk/ui/sidebar
No longer depends on: sdk/ui/sidebar
|
||
Updated•11 years ago
|
Priority: -- → P2
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → evold
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8448880 -
Flags: review?(zer0)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8448880 [details] [review] Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1534 Looks good to me, added some nits / suggestions in PR.
Attachment #8448880 -
Flags: review?(zer0) → review+
|
||
Comment 3•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/84800f2545638ee55a464f1a09ae7ae164e96c51 Bug 888773 - Sidebar followup: show/hide should take a window argument https://github.com/mozilla/addon-sdk/commit/c150649d34f3a740530d93a49e2e0404d387b146 Merge pull request #1534 from erikvold/888773 Bug 888773 - Sidebar show/hide should take a window argument r=@ZER0
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•