888783 - PRenderFrame should not allocate PLayerTransaction

Status: RESOLVED DUPLICATE of bug 1056427

(Core :: Graphics: Layers, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 2

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Need to move the ipc mochitests to their own test suite first.
https://tbpl.mozilla.org/?tree=Try&rev=66241bc14cb9

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 769569 [details] [diff] [review]
Patch

Review of attachment 769569 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome. Hope you can get the tests sorted out so that this passes.

Comment 4

[Matt Woodrow (:mattwoodrow)]

http://mxr.mozilla.org/mozilla-central/source/layout/ipc/RenderFrameParent.cpp#611

This branch should be an assert too.

Comment 5

[David Zbarsky (:dzbarsky)]

Attachment: Part 0: Disable remote frames when OMTC is disabled

It doesn't really make sense to be doing this.  By turning off remote frames we lose some test coverage, but it should be ok because the tests are cross-platform and will still run on platforms with OMTC. I've talked to dvander and billm and they're ok with this.

Comment 6

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 785927 [details] [diff] [review]
Part 0: Disable remote frames when OMTC is disabled

Sorry, I don't think I can make this call :(

Deferring to a super-reviewer, but it might make sense to have the owners of the tests weight in too.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Won't this break the e10s thumbnailing stuff that's turned on now?

Comment 8

[David Zbarsky (:dzbarsky)]

How does the e10s thumbnailing render anything on platforms without OMTC?  I don't think we do anything useful with the layers transactions that come through RenderFrameParent

Comment 9

[Matt Woodrow (:mattwoodrow)]

It doesn't render anything to a real window. It just does drawWindow calls within the process. The Compositor/RenderFrame etc connections aren't doing anything useful.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Right. Layers transactions already aren't coming through for those e10s thumbnailing windows on non-OMTC platforms, but that's fine. But this patch will make them stop being remote altogether, which is not fine.

Comment 11

[David Zbarsky (:dzbarsky)]

Ok, I think we can fix tests to not try to create remote iframes without OMTC but still allow the thumbnailing service to do its thing.