Closed Bug 88879 Opened 25 years ago Closed 24 years ago

Advanced Edit: TARGET attribute has incorrect default values

Categories

(SeaMonkey :: Composer, defect, P3)

Product:
SeaMonkey
Component:
Composer
Platform:
x86
Other
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.6

People

(Reporter: rubydoo123, Assigned: cmanske)

Details

(Whiteboard: [dialog] EDITORBASE)

Attachments

(1 file, 1 obsolete file)

Take 2: include "_" in attribute values strings and don't remove "_" when building the menulist
2.07 KB, patch
timeless
: review+
kinmoz
: superreview+
Details | Diff | Splinter Review
the TARGET attribute default values from the drop down should be: _blank _self _parent _top
Keywords: correctness
Priority: -- → P3
Whiteboard: [dialog]
Target Milestone: --- → mozilla1.0
changing milestone to 0.9.4
Status: NEW → ASSIGNED
Target Milestone: mozilla1.0 → mozilla0.9.4
Keywords: review
Whiteboard: [dialog] → [dialog]FIX IN HAND need r=, sr=
Fix is to add this to EdAEAttributes.js: +gHTMLAttr.form_target = +[ + "blank", + "self", + "parent", + "top" +];
sr=kin@netscape.com
Whiteboard: [dialog]FIX IN HAND need r=, sr= → [dialog]FIX IN HAND need r=
r=brade
Whiteboard: [dialog]FIX IN HAND need r= → [dialog]FIX IN HAND
Whiteboard: [dialog]FIX IN HAND → [dialog]FIX IN HAND, reviewed
checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Keywords: review
Resolution: --- → FIXED
Whiteboard: [dialog]FIX IN HAND, reviewed → [dialog]
Maybe I am misunderstanding the steps to reproduce this bug, but... When I go to advanced edit for a link, and select target in the attribute dropdown; I don't see any dropdown or default in the values field. I am attempting to verify this on Windows 98 SE, Mac OS 9.1 with the 8-30 build. Here are the steps I am following 1. open composer 2. create a link 3. in the link properties window click on Advanced edit 4. select "target" from the attribute dropdown EXPECTED: Value field becomes a dropdown with values: _blank _self _parent _top ACTUAL: Value field remains a text field... I apologize if I am missing something. I am new to verifying bugs.
using the comm trunk build from 2001083103 on win98, the default values are not present for the TARGET attribute. I selected an active link, displayed the properties, selected Advanced and selected the TARGET attribute. Reopening
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
It was fixed for the <form> element, so we're supposed to use the same set of values for all elements that have "target" attribute? That's not what original bug said!
Status: REOPENED → ASSIGNED
Target Milestone: mozilla0.9.4 → mozilla0.9.5
you are right, all instances of the TARGET attribute should only contain the listed values as the default values.
Is this critical for 0.9.5? If not, please renominate ("---", nsbeta1 keyword) or push to a later milestone.
spam composer change
Component: Editor: Core → Editor: Composer
Whiteboard: [dialog] → [dialog] EDITORBASE (1/2 day)
Summary: Advanced Edit: Form element, TARGET attribute has incorrect default values → Advanced Edit: TARGET attribute has incorrect default values
Whiteboard: [dialog] EDITORBASE (1/2 day) → [dialog] EDITORBASE (work done)
Attached patch Fix (obsolete) — — Splinter Review
Keywords: patch, review
Whiteboard: [dialog] EDITORBASE (work done) → [dialog] EDITORBASE, FIX IN HAND need r=,sr=
Comment on attachment 51582 [details] [diff] [review] Fix r=brade
Attachment #51582 - Flags: review+
Whiteboard: [dialog] EDITORBASE, FIX IN HAND need r=,sr= → [dialog] EDITORBASE, FIX IN HAND need sr=
Keywords: review
Whiteboard: [dialog] EDITORBASE, FIX IN HAND need sr= → [dialog] EDITORBASE, FIX IN HAND, reviewed
checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
Keywords: patch
Resolution: --- → FIXED
Whiteboard: [dialog] EDITORBASE, FIX IN HAND, reviewed → [dialog] EDITORBASE
on the 10-03 Trunk Build the values are currently: blank self parent top They should be: (with the leading underscore) _blank _self _parent _top At least that was my understanding of the target attribute. Please let me know if I am wrong, or need to look at a different build.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Oops! Nope, I just forgot about the "_"!!!
Status: REOPENED → ASSIGNED
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Attachment #51582 - Attachment is obsolete: true
Keywords: patch, review
Whiteboard: [dialog] EDITORBASE → [dialog] EDITORBASE, FIX IN HAND, need r=,sr=
Comment on attachment 52113 [details] [diff] [review] Take 2: include "_" in attribute values strings and don't remove "_" when building the menulist sr=kin@netscape.com
Attachment #52113 - Flags: superreview+
Comment on attachment 52113 [details] [diff] [review] Take 2: include "_" in attribute values strings and don't remove "_" when building the menulist r=timeless
Attachment #52113 - Flags: review+
checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
Keywords: patch, review
Resolution: --- → FIXED
Whiteboard: [dialog] EDITORBASE, FIX IN HAND, need r=,sr= → [dialog] EDITORBASE
Verified on 10-16 build
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: