888828 - Default route of 3G data call disappeared (after receiving disconnected event from wlan0)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Shian-Yow Wu [:swu]]

I tested this on Unagi device using mozill-central code.

STR:
1. Establish data call, and make sure default route of rmnet0 exists.
2. Enable Wifi, but don't connect to any Wifi network.
3. Wait until receiving state change event (NETWORK_STATE_DISCONNECTED) from wlan0.
4. Default route of rmnet0 disappeared.

Below is the NetworkManager log for this problem.

=== BEFORE ===

uid=0 gid=0@android:/ # route -n                                               
Kernel IP routing table
Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
0.0.0.0         100.73.137.225  0.0.0.0         UG    0      0        0 rmnet0
100.73.137.224  0.0.0.0         255.255.255.240 U     0      0        0 rmnet0
168.95.1.1      100.73.137.225  255.255.255.255 UGH   0      0        0 rmnet0
168.95.192.1    100.73.137.225  255.255.255.255 UGH   0      0        0 rmnet0


I/Gecko   (  622): -*- NetworkManager: NetworkManager received message from worker: {"id":"broadcast","topic":"netd-interface-change","reason":"Iface linkstate wlan0 down"}
I/Gecko   (  622): -*- NetworkManager: NetworkManager received message from worker: {"id":"broadcast","topic":"netd-interface-change","reason":"Iface linkstate wlan0 down"}
I/Gecko   (  622): -*- NetworkManager: Network wlan0 changed state to 3
I/Gecko   (  622): -*- NetworkManager: Evaluating whether active network needs to be changed.
I/Gecko   (  622): -*- NetworkManager: Going to change route and DNS to rmnet0
I/Gecko   (  622): -*- NetworkManager: ===== setDefaultRouteAndDNS() {"cmd":"setDefaultRouteAndDNS","ifname":"rmnet0","oldIfname":null,"gateway_str":"100.73.137.225","dns1_str":"168.95.1.1","dns2_str":"168.95.192.1"}
I/Gecko   (  622): -*- NetworkManager: No proxy support for rmnet0 network interface.
I/Gecko   (  622): -*- NetworkManager: NetworkManager received message from worker: {}
I/Gecko   (  622): -*- NetworkManager: NetworkManager received message from worker: {}
I/Gecko   (  622): -*- NetworkManager: NetworkManager received message from worker: {"id":"broadcast","topic":"netd-interface-change","reason":"Iface linkstate wlan0 down"}
I/Gecko   (  622): -*- NetworkManager: NetworkManager received message from worker: {"id":"broadcast","topic":"netd-interface-change","reason":"Iface linkstate wlan0 down"}

=== AFTER ===

uid=0 gid=0@android:/ # route -n                                               
Kernel IP routing table
Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
168.95.1.1      100.73.137.225  255.255.255.255 UGH   0      0        0 rmnet0
168.95.192.1    100.73.137.225  255.255.255.255 UGH   0      0        0 rmnet0

Comment 1

[Shian-Yow Wu [:swu]]

Log with both "Network Worker" and NetworkManager.

I/Gecko   (  108): -*- NetworkManager: Network wlan0 changed state to 3
I/Gecko   (  108): Network Worker: received message: {"cmd":"removeNetworkRoute","ifname":"rmnet0","ip":"100.74.66.19","netmask":"255.255.255.248"}
I/Gecko   (  108): -*- NetworkManager: Evaluating whether active network needs to be changed.
I/Gecko   (  108): -*- NetworkManager: Going to change route and DNS to rmnet0
I/Gecko   (  108): -*- NetworkManager: ===== setDefaultRouteAndDNS() {"cmd":"setDefaultRouteAndDNS","ifname":"rmnet0","oldIfname":null,"gateway_str":"100.74.66.17","dns1_str":"168.95.1.1","dns2_str":"168.95.192.1"}
I/Gecko   (  108): Network Worker: received message: {"cmd":"setDefaultRouteAndDNS","ifname":"rmnet0","oldIfname":null,"gateway_str":"100.74.66.17","dns1_str":"168.95.1.1","dns2_str":"168.95.192.1"}
I/Gecko   (  108): -*- NetworkManager: No proxy support for rmnet0 network interface.

For unknown reason, after routing table removed by removeNetworkRoute(), default route was not added successfully by setDefaultRouteAndDNS().

Comment 2

[Dimi Lee [:dimi]]

Attachment: Fix for bug 888828

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/0bfcc6f663bb

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0bfcc6f663bb

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

https://bugzilla.mozilla.org/show_bug.cgi?id=834573#c18

seem like we need to make uplifts to fix this bug in v1.1 and possibly v1.2 branches?

Comment 6

[Kai-Chih Hu [:khu]]

Maybe we can go for v1.1?

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

leo+. this will cause data connection problems after a device is disconnected from wifi

Comment 8

[Dimi Lee [:dimi]]

Attachment: Bug_888828_fix_for_1_1_HD.patch

Comment 9

[Ryan VanderMeulen [:RyanVM]]

This landed on m-c well before Gecko26, so it's already fixed in v1.2. If something isn't working there, you should probably file a new bug for it.

https://hg.mozilla.org/releases/mozilla-b2g18/rev/87cd74983a39

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/87cd74983a39