888871 - [CALL LOG] There is no confirmation screen when deleting a record in the call log

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[rafael.marquez]

*PROCEDURE
1.Launch the Dialer app.
2.Tap to open the call log and open the missed calls tab.
3.Tap the Edit button in the top right corner to enter edit mode.
4.Tap the button Select all when there is only one call in the Call log.
5. Tap the Delete button 

*Actual Result
A confirmation screen is displayed after press delete button

*Expected Result
There is no confirmation screen when deleting a record in the call log

Comment 1

[rafael.marquez]

Sorry, the correct structure:

*Expected Result
A confirmation screen is displayed after press delete button

*Actual Result
There is no confirmation screen when deleting a record in the call log

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/10733

This PR has include confirmation screen before deleting call log, and some locales properties which requires l10n to review and modify.

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 770034 [details]
https://github.com/mozilla-b2g/gaia/pull/10733

r=me with the tiny nit on github addressed.

Flagging the UX team for review on the new strings, we can tweak them before landing if needed.

Thanks! And thanks to German for looking at this too.

Comment 4

[Alex Keybl [:akeybl]]

I'm very confused how this is both late-l10n and a regression. If it's a regression, what's preventing us from going back to a known state? We need to be limiting string change as much as possible.

Comment 5

[Stephany Wilkes]

I am with Alex: if this is a regression, we should return to a known state. UX is not blocking on late string changes.

Comment 6

[rafael.marquez]

I'm not 100% sure, but I think is a regression

Comment 7

[bhavana bajaj [:bajaj]]

Needsinfo on leo to confirm if they really meant to nominate this ? In triage we had discussed this was not-blocking, hence when you are in disagreement a comment will really be helpful.Thanks !

Comment 8

[bhavana bajaj [:bajaj]]

Also added qawanted to check if this is a regression as discussed in triage with Jason

Comment 9

[Darren]

Issue was last reproducible on build: 20130524070209
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/c4378ff5d057
Gaia: cc2fd02fd461aa12c96e02229a78293365d65264

The delete confirmation appears on the 0524 build, but not the 0525 build.

Let me know if you need more information.

Comment 10

[Natalya Kot [:nkot]]

removing "qawanted", comment 9 confirms it's a regression, 

exact regression range:
 Build  20130524070209 - PASS
 Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/c4378ff5d057
 Gaia   cc2fd02fd461aa12c96e02229a78293365d65264

 Build  20130524230207 - FAIL
 Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/c4378ff5d057
 Gaia   4d10e1297b859cacc174c0a54af61a7678d7c32d

Comment 11

[bhavana bajaj [:bajaj]]

George this looks like a regression based on QA testing in comment 10, then why does it require new string to fix the issue ?

Comment 12

[Wayne Chang [:wchang]]

Triage with Leo, not blocking for leo as late-l10n and schedule concerns.
Suggesting to move to koi.

Comment 13

[(Inactive after June) George Duan [:gduan] [:喬智]]

In reply to comment 11 and comment 10,

Thanks for your information. You're correct.

After tracking the history, I found this is a regression of Bug 847406( mainly to refactor dialer's code). The original function for delete dialog exist in recents.js, but after refactoring, dialer has removed the dependency of it. If it's correct, I think it's ok to use my patch.

Hi Etienne, what do you think about that?

Comment 14

[Darren]

Created a test case covering the confirmation prompt for deleting call logs.

https://moztrap.mozilla.org/manage/cases/?filter-id=9247

Comment 15

[Etienne Segonzac (:etienne)]

(In reply to bhavana bajaj [:bajaj] from comment #11)
> George this looks like a regression based on QA testing in comment 10, then
> why does it require new string to fix the issue ?

The old code probably used the following l10n key:
confirm-deletion=Clear selected calls?

The new patch just has a nicer message.

Since it's not leo+ let's land this nicer patch on master.

Comment 16

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: Delete confirm dialog

Hi Etienne,
I just rebased it and fixed some conflicts. should I land it to master now?

Comment 17

[Etienne Segonzac (:etienne)]

(In reply to George Duan [:gduan] from comment #16)
> Created attachment 786106 [details]
> Delete confirm dialog
> 
> Hi Etienne,
> I just rebased it and fixed some conflicts. should I land it to master now?

Yes!

Comment 18

[(Inactive after June) George Duan [:gduan] [:喬智]]

Merge into master
https://github.com/mozilla-b2g/gaia/commit/39504e7b65adc237a42b576fd0e0ff7465daebce

Comment 19

[rafael.marquez]

Bug solved and tested with satisfactory result in master branch