Status

()

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Tracking

(Blocks 1 bug, {meta, sec-other})

17 Branch
mozilla30
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox22 wontfix, firefox23+ wontfix, firefox24+ wontfix, firefox25 wontfix, firefox26 wontfix, firefox27 wontfix, firefox28- fixed, firefox29 fixed, firefox30 fixed, firefox-esr17 wontfix, firefox-esr24 wontfix, b2g18 wontfix, b2g-v1.1hd wontfix, b2g-v1.2 wontfix, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)

Details

(Whiteboard: [adv-main28-])

Attachments

(1 attachment, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #879787 +++

Need to land additional tests from bug 879787 and also land bug 882458.
Can we do this now?
Assignee: nobody → bent.mozilla
Oops, I need a patch.
Keywords: checkin-needed
Normally we wait six weeks after a public release to land tests to guarantee uptake from affected versions to avoid potential 0 days.
(In reply to Al Billings [:abillings] from comment #4)

Sorry, now I see that dveditz said "early August" (bug 879787 comment 15). You're totally right. This needs to wait.
Whiteboard: [checkin after 7/1] → [checkin in early August]
Can the patch be prepared early though?  Would probably be helpful for getting this checked in to our final beta/rc of FF23
Time to get a patch ready as we'll build our final beta on Monday for our Aug 6th release candidate. Ben do you have this ready?
Flags: needinfo?(bent.mozilla)
Posted patch changes.patch (obsolete) — Splinter Review
Attachment #782014 - Flags: review+
Flags: needinfo?(bent.mozilla)
Actually, it's too rushed to get this into FF23 and we're still in July, technically, so let's target this for FF24.
Ben, it should be okay to move forward here, as we're past early August.
Flags: needinfo?(bent.mozilla)
Al, what's the procedure here? Do I just land this now? Is there even a need to keep this bug hidden any longer?
Flags: needinfo?(bent.mozilla) → needinfo?(abillings)
Just land it and open the bug.
Okay, maybe not, Al posted a discussion on the sec list about this...
Whiteboard: [checkin in early August]
(In reply to Andrew McCreight [:mccr8] from comment #12)
> Just land it and open the bug.

No -- don't open the bug! The underlying bug 879787 may be fixed in Firefox 23 and ESR 17.0.8 but it's not yet been shipped on a b2g device.

I guess we could check in the tests now and figure no one's likely to notice (trunk only!). It'd be best if you could combine it with the checkin for public bug 882458 and leave the number for this bug and 879787 out of the check-in comment.
Dan - why is this tracking for FF26?  Was that to make sure this got on B2G 1.2 branch? If so, it's no longer with FF26 and is on its own branch so we should update the flags accordingly.  I don't see anything here that needs to land on mozilla-beta.
Flags: needinfo?(dveditz)
If you want this on B2G 26 please flag koi? with explanation of why its needed.
The underlying bug is fixed everywhere we care about (ESR17,B2G1.1, etc). We can now safely check in the tests on trunk. The tracking flag was just to make sure this did, in fact, get checked in.
Backed out for mochitest failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2ac793ec024

Not sure what I did wrong when rebasing this into mochitest.ini land, but I'm pretty sure that test_xhr_headers_server.sjs isn't supposed to be trying to run by itself...

https://tbpl.mozilla.org/php/getParsedLog.php?id=30272436&tree=Mozilla-Inbound
You can't call support files test_*; the runner will happily run everything starting with test_ for now.
(In reply to Daniel Veditz [:dveditz] from comment #17)
> The underlying bug is fixed everywhere we care about (ESR17,B2G1.1, etc). We
> can now safely check in the tests on trunk.

So can we open this bug now?
Flags: needinfo?(bent.mozilla)
it looks like these tests did not land yet - can you update the patch?
Flags: needinfo?(bent.mozilla)
Flags: needinfo?(bent.mozilla)
Posted patch TestsSplinter Review
https://tbpl.mozilla.org/?tree=Try&rev=6e08d8e0b64b
Attachment #782014 - Attachment is obsolete: true
Attachment #8379764 - Flags: review+
Flags: needinfo?(bent.mozilla)
tests landed on central https://hg.mozilla.org/mozilla-central/rev/24ca86629095
Target Milestone: --- → mozilla30
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Can we open this?
Group: core-security
We're at the final FF28 beta today, wontfixing this for 28 as it has been before.  If this can get nominated for 29, great, otherwise it looks like we've been fine for so long that there's a low priority here.
Whiteboard: [adv-main28-]
You need to log in before you can comment on or make changes to this bug.