888974 - Add worker tests from bug 879787

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

+++ This bug was initially created as a clone of Bug #879787 +++

Need to land additional tests from bug 879787 and also land bug 882458.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Can we do this now?

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Yes

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Oops, I need a patch.

Comment 4

[Al Billings [:abillings - ex-MoCo]]

Normally we wait six weeks after a public release to land tests to guarantee uptake from affected versions to avoid potential 0 days.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to Al Billings [:abillings] from comment #4)

Sorry, now I see that dveditz said "early August" (bug 879787 comment 15). You're totally right. This needs to wait.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Can the patch be prepared early though?  Would probably be helpful for getting this checked in to our final beta/rc of FF23

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Time to get a patch ready as we'll build our final beta on Monday for our Aug 6th release candidate. Ben do you have this ready?

Comment 8

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: changes.patch

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Actually, it's too rushed to get this into FF23 and we're still in July, technically, so let's target this for FF24.

Comment 10

[Andrew McCreight [:mccr8]]

Ben, it should be okay to move forward here, as we're past early August.

Comment 11

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Al, what's the procedure here? Do I just land this now? Is there even a need to keep this bug hidden any longer?

Comment 12

[Andrew McCreight [:mccr8]]

Just land it and open the bug.

Comment 13

[Andrew McCreight [:mccr8]]

Okay, maybe not, Al posted a discussion on the sec list about this...

Comment 14

[Daniel Veditz [:dveditz]]

(In reply to Andrew McCreight [:mccr8] from comment #12)
> Just land it and open the bug.

No -- don't open the bug! The underlying bug 879787 may be fixed in Firefox 23 and ESR 17.0.8 but it's not yet been shipped on a b2g device.

I guess we could check in the tests now and figure no one's likely to notice (trunk only!). It'd be best if you could combine it with the checkin for public bug 882458 and leave the number for this bug and 879787 out of the check-in comment.

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Dan - why is this tracking for FF26?  Was that to make sure this got on B2G 1.2 branch? If so, it's no longer with FF26 and is on its own branch so we should update the flags accordingly.  I don't see anything here that needs to land on mozilla-beta.

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

If you want this on B2G 26 please flag koi? with explanation of why its needed.

Comment 17

[Daniel Veditz [:dveditz]]

The underlying bug is fixed everywhere we care about (ESR17,B2G1.1, etc). We can now safely check in the tests on trunk. The tracking flag was just to make sure this did, in fact, get checked in.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa013ffd209b

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Backed out for mochitest failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2ac793ec024

Not sure what I did wrong when rebasing this into mochitest.ini land, but I'm pretty sure that test_xhr_headers_server.sjs isn't supposed to be trying to run by itself...

https://tbpl.mozilla.org/php/getParsedLog.php?id=30272436&tree=Mozilla-Inbound

Comment 20

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

You can't call support files test_*; the runner will happily run everything starting with test_ for now.

Comment 21

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Daniel Veditz [:dveditz] from comment #17)
> The underlying bug is fixed everywhere we care about (ESR17,B2G1.1, etc). We
> can now safely check in the tests on trunk.

So can we open this bug now?

Comment 22

[Lukas Blakk [:lsblakk] use ?needinfo]

it looks like these tests did not land yet - can you update the patch?

Comment 23

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Tests

https://tbpl.mozilla.org/?tree=Try&rev=6e08d8e0b64b

Comment 24

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/24ca86629095

Comment 25

[Carsten Book [:Tomcat]]

tests landed on central https://hg.mozilla.org/mozilla-central/rev/24ca86629095

Comment 26

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Can we open this?

Comment 27

[Lukas Blakk [:lsblakk] use ?needinfo]

We're at the final FF28 beta today, wontfixing this for 28 as it has been before.  If this can get nominated for 29, great, otherwise it looks like we've been fine for so long that there's a low priority here.

Comment 28

[Ryan VanderMeulen [:RyanVM]]

These apply cleanly to aurora/beta so landed a=test-only after discussing w/ Lukas.

https://hg.mozilla.org/releases/mozilla-aurora/rev/1d3b70607239
https://hg.mozilla.org/releases/mozilla-beta/rev/94ff7bdd6c67

Comment 29

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Thanks guys!

Comment 30

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/94ff7bdd6c67