Closed
Bug 889016
Opened 11 years ago
Closed 11 years ago
Hide the synchronous AudioContext.createBuffer function behind a pref
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
| Tracking | Status | |
|---|---|---|
| firefox23 | --- | unaffected |
| firefox24 | + | fixed |
| firefox25 | + | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Whiteboard: [blocking-webaudio+][qa-])
Attachments
(2 files, 1 obsolete file)
|
3.21 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
5.87 KB,
patch
|
bzbarsky
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug 889014 blocks doing this...
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [blocking-webaudio+]
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #770941 -
Flags: review?(roc)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 770940 [details] [diff] [review] Part 1: Add an API to report a not-enough-arguments error in Web IDL bindings This patch adds an internal API which is used by Web Audio in part 2. It should not affect the behavior of existing code. No string or uuid changes.
Attachment #770940 -
Flags: approval-mozilla-aurora?
|
||
Updated•11 years ago
|
status-firefox23:
--- → unaffected
status-firefox24:
--- → affected
status-firefox25:
--- → affected
tracking-firefox24:
--- → +
tracking-firefox25:
--- → +
|
|
Assignee | |
Comment 4•11 years ago
|
||
I believe I failed to attach the latest version of the patch!
Attachment #770940 -
Attachment is obsolete: true
Attachment #770940 -
Flags: review?(bzbarsky)
Attachment #770940 -
Flags: approval-mozilla-aurora?
Attachment #770995 -
Flags: review?(bzbarsky)
Attachment #770995 -
Flags: approval-mozilla-aurora?
Comment on attachment 770941 [details] [diff] [review] Part 2: Report an error in the synchronous AudioContext.createBuffer unless the legacy pref has been set Review of attachment 770941 [details] [diff] [review]: ----------------------------------------------------------------- Why isn't this just pref-controlled in the WebIDL?
|
|
Assignee | |
Comment 6•11 years ago
|
||
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #5) > Comment on attachment 770941 [details] [diff] [review] > Part 2: Report an error in the synchronous AudioContext.createBuffer unless > the legacy pref has been set > > Review of attachment 770941 [details] [diff] [review]: > ----------------------------------------------------------------- > > Why isn't this just pref-controlled in the WebIDL? See bug 889014. Basically we can't have extended different attributes on overloads, so [Pref] is not an option here. I chatted with Boris on the bug and on IRC today and this was the simplest way that we could think of in order to implement this.
Attachment #770941 -
Flags: review?(roc) → review+
|
||
Comment 7•11 years ago
|
||
Comment on attachment 770995 [details] [diff] [review] Part 1: Add an API to report a not-enough-arguments error in Web IDL bindings r=me
Attachment #770995 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bdf3f4ac0fe https://hg.mozilla.org/integration/mozilla-inbound/rev/bc99f68f8946
|
|
Assignee | |
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1bdf3f4ac0fe https://hg.mozilla.org/mozilla-central/rev/bc99f68f8946
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
|
||
Comment 10•11 years ago
|
||
Comment on attachment 770995 [details] [diff] [review] Part 1: Add an API to report a not-enough-arguments error in Web IDL bindings Approving as this is blocking webaudio on Fx24.
Attachment #770995 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 11•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/b962ab6c33b6 https://hg.mozilla.org/releases/mozilla-aurora/rev/86bb41319505
|
||
Comment 12•11 years ago
|
||
Assuming no QA needed here. Please remove [qa-] from the whiteboard and add the verifyme keyword if this needs QA.
Whiteboard: [blocking-webaudio+] → [blocking-webaudio+][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•