889056 - Supporting countries behind a whitelist when payments goes live

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[krupa raj[:krupa]]

Currently, our payments whitelist is all or nothing at all when it comes to regions.

However, this week we launch payments for Moss. We need payments still to be accessible behind a whitelist for regions like Seville, Durango and Seahorse.

Comment 1

[Andy McKay]

So to confirm there is the search flag whitelist and the webpay whitelist. 

We'll probably just have to remove the webpay whitelist completely since that's based on email.

Comment 2

[Andy McKay]

So we need to be able to:

* when users submit paid apps show the upcoming regions and price tiers
* have the search flag be region specific, so that regions such as Moss do not check the flag, its open to anyone - but Seville, Durango and Seahorse do check the flag
* have the webpay whitelist be region specific, so that regions such as Moss do not check the whitelist, its open to anyone - bug Seville, Durango and Seahorse do check the flag

Suggestions in irc:

* one waffle flag per region
* an extra value on constants (which already has the has_payments field, such as can_purchase)

Comment 3

[Wil Clouser [:clouserw]]

can_purchase seems pretty clean to me, assuming there is a solid comment in the code about what it is

Comment 4

[Christopher Van Wiemeersch [:cvan]]

Also, how should Fireplace have knowledge of availability per region/price tier? See bug 883958 comment 4 for my thinking.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

Ugh, just realised: we need to hide upsell (in the API response) if it's unavailable for purchase in that region:
https://github.com/mozilla/fireplace/blob/master/hearth/templates/detail/main.html#L186

Comment 6

[Andy McKay]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #4)
> Also, how should Fireplace have knowledge of availability per region/price
> tier? See bug 883958 comment 4 for my thinking.

We'll also need to change the API to check the can_purchase flag, if it fails you'll have a price of None, but the type is premium and payment required is True. This is the API output as trying to purchase in a region that not supported by payments at all.

Comment 7

[Andy McKay]

https://github.com/mozilla/zamboni/commit/0fd4a2