889111 - Plus sign is converted to space for email accounts that have them

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[raymond [:retornam] (inactive)]

STR:
1) Sign up with an email address with a plus in it eg [e-mail]
2) Visit your account page. Notice that the plus sign is converted to a space, this makes it difficult to sign-up for the newsletter or to receive emails from marketplace.

3 See http://cl.ly/image/3A0T3p311y2A

Comment 1

[Davor Spasovski [:spasovski]]

Allan can you take a look at this?

Comment 2

[Matt Basta [:basta]]

This is because we're converting the + to a space on the client (since, urldecoded, it translates a space).

Comment 3

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/fireplace/commit/e986245

That should prevent future emails getting saved poorly. Much thanks to basta.

Comment 4

[Matt Basta [:basta]]

STR:

1. Sign in with an affected email
2. Visit settings page
3. Save settings
4. Reload the page
5. Check that the email listed has not converted the + to a space.

Comment 5

[raymond [:retornam] (inactive)]

fixed on dev. The email address listed has the + sign


https://marketplace-dev.allizom.org/

Comment 6

[Iulian Timis]

Verified as fixed in MP-dev app on Unagi.
Attaching postfix screenshot.
Closing bug.

Comment 7

[Iulian Timis]

Attachment: postfix plus sign