889148 - Remove unused QS/classinfo bits even more

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=4a89a2ae0e8d

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 769929 [details] [diff] [review]
patch

peterv should give his r+ for the DOMCI_CASTABLE_INTERFACE changes.

+DOMCI_CASTABLE_INTERFACE(mozilla::dom::EventTarget,                    \
+                         mozilla::dom::EventTarget, 0, _extra)         \
Why you need the latter \

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 769929 [details] [diff] [review]
patch

Review of attachment 769929 [details] [diff] [review]:
-----------------------------------------------------------------

r- just for the DOMCI_CASTABLE_INTERFACE changes, take them out and land the rest.

::: dom/base/nsDOMClassInfo.cpp
@@ +232,5 @@
>  #include "nsIDOMMediaQueryList.h"
>  
>  #include "mozilla/dom/Activity.h"
>  
> +#include "nsDOMTouchEvent.h" //nsDOMTouchEvent::PrefEnabled

Don't do this.

::: dom/base/nsDOMClassInfoID.h
@@ -63,5 @@
> -DOMCI_CASTABLE_INTERFACE(nsStyledElement, nsStyledElement, 8, _extra)         \
> -DOMCI_CASTABLE_INTERFACE(nsSVGElement, nsIContent, 9, _extra)                 \
> -/* NOTE: When removing the casts below, remove the nsDOMEventBase class */    \
> -DOMCI_CASTABLE_INTERFACE(nsDOMMouseEvent, nsDOMEventBase, 10, _extra)         \
> -DOMCI_CASTABLE_INTERFACE(nsDOMUIEvent, nsDOMEventBase, 11, _extra)

We have explicitly not done this while we have quickstubs left, NEW_BINDING still uses DOMCI_CASTABLE_INTERFACE. We could go through the remaining quickstubs and take out what's unused, but I'd rather remove it all at once at the end.

Comment 3

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/296f84d14045

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/296f84d14045