889174 - [Leo] Some Pictures taken with Leo device default to Sepia image

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Picture of light fixture taken with Keon Device

Leo device, while running:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/15923aca6e6d
Gaia   c7472acec84f0d4527cdd6fd555d289e1d3e1d1d
BuildID 20130701070213
Version 18.0

STR:
1. Take a picture of the light fixture above me with Leo device
2. Repeat steps with Keon or Ikura device

Leo device consistently takes a photo which looks as if it has a brown filter. The Keon and Ikura devices take the same picture and it is much more representative of what the fixture actually looks like.

Comment 1

[Marcia Knous [:marcia]]

Attachment: Picture of same light fixture taken with Leo device

Comment 2

[Marcia Knous [:marcia]]

Note that the Leo screenshot has no "effects" on it - that it how it shot out of the box. Maybe a white balance issue?

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

This looks like a white-balance issue to me. For v1.1 we leave the driver/camera in "auto" mode.

Comment 4

[Andrew Overholt [:overholt]]

Has this always been the case for v1.1 on leo devices?

Mike, should we ask the camera driver vendor for a fix here?

Comment 5

[Mike Habicher [:mikeh] (high bugzilla latency)]

Andrew, we've always just left the white balance in auto mode.

Marcia, do all pictures have a brown cast? or just pictures of that fluorescent lighting fixture?

Just to be clear, is "brownish" different from "sepia"? The latter would be a valid (and possibly incorrectly-configured) camera effect.

Comment 6

[Marcia Knous [:marcia]]

Mike: Using the Leo build from yesterday, all regular pictures seem to render fine. The picture in the bug is from the fluorescent light in the MV office, and it seems if you go to to the first choice under "Effects" Edit | Camera that it matches that effect, which seems to be Sepia and not brown.

I am not sure if that has always been the case, but I could flash back to an earlier build/base build and check if the same thing is happening. Note I am using the newest Leo Base image v08j which seems to have a few issues reported such as Bug 889020.

Comment 7

[Mike Habicher [:mikeh] (high bugzilla latency)]

Marcia, I don't think there's any need to go back to older versions. It sounds like there's a lot of churn in the leo builds these days--let's keep this bug open for the next little while, and close it if there's no reappearance of this issue.

Comment 8

[Marcia Knous [:marcia]]

Two data points: 

* The older base image with 6-25 phone shows the same thing (jhammink had a phone handy). 
* My Samsung Galaxy S3 android phone also has a sepia tint to it when taking a photo of the same light fixture.

Comment 9

[Dietrich Ayala (:dietrich)]

Requesting vendor comment.

Comment 10

[Leo]

Attachment: Image screen shots

Hi,

I am able to reproduce this issue with Leo device.

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

This looks like a partner call based on what the hardware/vendor limitations are on the camera here. If it's matching what the S3 takes, then this looks like a non-blocker unless partners want to have a different lighting in default photos and will work with vendors on developing that.  In either case this isn't something we can change in our code.

Comment 12

[Mike Habicher [:mikeh] (high bugzilla latency)]

leo, can you confirm what white balance and effects the camera is defaulting to when this happens? I'm wondering if it's a flaky "default" option, or if the driver is getting some kind of randomly initialized setting.

Adding:
  dump("this._cameraObj.whiteBalanceMode=" + this._cameraObj.whiteBalanceMode);
  dump("this._cameraObj.effect=" + this._cameraObj.effect);

...to a suitable place in camera.js will easily let us see what the camera things is going on.

Comment 13

[Sotaro Ikeda [:sotaro]]

(In reply to Mike Habicher [:mikeh] PTO until Aug 5 from comment #12)
> Adding:
>   dump("this._cameraObj.whiteBalanceMode=" +
> this._cameraObj.whiteBalanceMode);
>   dump("this._cameraObj.effect=" + this._cameraObj.effect);
> 
> ...to a suitable place in camera.js will easily let us see what the camera
> things is going on.

From the above code, I got following on v1.1 leo.

> I GeckoDump: this._cameraObj.whiteBalanceMode=auto
> I GeckoDump: this._cameraObj.effect=none

Comment 14

[Sotaro Ikeda [:sotaro]]

It seems easier to check camera setting by using android::CameraParameters::dump().

Comment 15

[Sotaro Ikeda [:sotaro]]

Attachment: CameraParameters's dump

Got camera parameters used on v1.1 leo by using modified android::CameraParameters::dump().

Comment 16

[Sotaro Ikeda [:sotaro]]

From attachment 780636 [details], mode settings are correct.

Comment 17

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #16)
> From attachment 780636 [details], mode settings are correct.

Leo, can you check the CameraParameters on your device and check if there is a problem?

Comment 18

[Sotaro Ikeda [:sotaro]]

From attachment 780636 [details], I feel it is not a problem of gecko side. It seems like problem of camera hw's adjustment.

Comment 19

[leo.bugzilla.fw]

This issue is not caused by FireFox OS but camera sensor Image Quality tunning.
For this reason, this issue report is not right to be uploaded on bugzilla.
We are going to tune image quality to fix this issue but not by Bugzilla.
Please change the status of this issue to LEO -
Thanks.

Comment 20

[Sotaro Ikeda [:sotaro]]

From comment #19, I un-assign myself.

Comment 21

[jongsoo.oh]

From comment #19, this issue is not needed to handle in bugzilla