88920 - gfx/src/gtk/nsFontMetricsGTK.cpp uses for-init-scope against c++ portability guide

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[John Mark Vandenberg]

gfx/src/gtk/nsFontMetricsGTK.cpp:799 causes build breakage on MIPSpro.

http://www.mozilla.org/hacking/portable-cpp.html#variables_in_for

Comment 1

[Chad Austin]

http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsFontMetricsGTK.cpp#799

I don't see what you're referring to...

Comment 2

[John Mark Vandenberg]

Attachment: gfx/src/gtk/nsFontMetricsGTK.cpp : Patch to compile on IRIX

Comment 3

[John Mark Vandenberg]

Sorry I didnt get the patch in before you had a look ... network glitch.  This 
is an example of the second non-portable code in that section of the c++ 
portability guide.

Comment 4

[John Mark Vandenberg]

See bug 86036 and bug 86259 for examples of this problem which keep turning up.

Comment 5

[John Morrison]

It looks to me (from lxr and bonsai) that jag checked in a fix for this on 
Saturday, at least on the trunk (rev 1.158). Is that sufficient?

Comment 6

[John Mark Vandenberg]

I am not sure what is going on re: 0.9.2 , as it seems this was fixed on the 
branch too.  Anyway ... sorry for the annoyance.

Comment 7

[jag (Peter Annema)]

Yeah, my patch is on the trunk and the branch. It's probably not the most
elegant way, but it works. If anyone wants to come up with something more
elegant in this bug and replace my patch, be my guest, otherwise I suggest we
close this.

Comment 8

[John Morrison]

Okay. Fixed. (I think the current fix is sufficient). And it is _not_ an 
annoyance to report a bug that is breaking ports! :-]

Comment 9

[Chad Austin]

verified checked in