gfx/src/gtk/nsFontMetricsGTK.cpp uses for-init-scope against c++ portability guide

VERIFIED FIXED

Status

()

VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: johnv, Assigned: jag-mozilla)

Tracking

Trunk
SGI
IRIX
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
gfx/src/gtk/nsFontMetricsGTK.cpp:799 causes build breakage on MIPSpro.

http://www.mozilla.org/hacking/portable-cpp.html#variables_in_for

Comment 1

18 years ago
http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsFontMetricsGTK.cpp#799

I don't see what you're referring to...
(Reporter)

Comment 2

18 years ago
Created attachment 40962 [details] [diff] [review]
gfx/src/gtk/nsFontMetricsGTK.cpp : Patch to compile on IRIX
(Reporter)

Comment 3

18 years ago
Sorry I didnt get the patch in before you had a look ... network glitch.  This 
is an example of the second non-portable code in that section of the c++ 
portability guide.
(Reporter)

Comment 4

18 years ago
See bug 86036 and bug 86259 for examples of this problem which keep turning up.

Comment 5

18 years ago
It looks to me (from lxr and bonsai) that jag checked in a fix for this on 
Saturday, at least on the trunk (rev 1.158). Is that sufficient?
Assignee: trudelle → jaggernaut
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Comment 6

18 years ago
I am not sure what is going on re: 0.9.2 , as it seems this was fixed on the 
branch too.  Anyway ... sorry for the annoyance.
(Assignee)

Comment 7

18 years ago
Yeah, my patch is on the trunk and the branch. It's probably not the most
elegant way, but it works. If anyone wants to come up with something more
elegant in this bug and replace my patch, be my guest, otherwise I suggest we
close this.

Comment 8

18 years ago
Okay. Fixed. (I think the current fix is sufficient). And it is _not_ an 
annoyance to report a bug that is breaking ports! :-]
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 9

17 years ago
verified checked in
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.