809 bytes, patch
|Details | Diff | Splinter Review|
gfx/src/gtk/nsFontMetricsGTK.cpp:799 causes build breakage on MIPSpro. http://www.mozilla.org/hacking/portable-cpp.html#variables_in_for
http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsFontMetricsGTK.cpp#799 I don't see what you're referring to...
Created attachment 40962 [details] [diff] [review] gfx/src/gtk/nsFontMetricsGTK.cpp : Patch to compile on IRIX
Sorry I didnt get the patch in before you had a look ... network glitch. This is an example of the second non-portable code in that section of the c++ portability guide.
It looks to me (from lxr and bonsai) that jag checked in a fix for this on Saturday, at least on the trunk (rev 1.158). Is that sufficient?
Assignee: trudelle → jaggernaut
Status: UNCONFIRMED → NEW
Ever confirmed: true
I am not sure what is going on re: 0.9.2 , as it seems this was fixed on the branch too. Anyway ... sorry for the annoyance.
Yeah, my patch is on the trunk and the branch. It's probably not the most elegant way, but it works. If anyone wants to come up with something more elegant in this bug and replace my patch, be my guest, otherwise I suggest we close this.
Okay. Fixed. (I think the current fix is sufficient). And it is _not_ an annoyance to report a bug that is breaking ports! :-]
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
verified checked in
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.