889219 - Clean up nsPrintEngine/nsSimplePageSequence a bit

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

While working on bug 886295 I did some cleanup patches that we should land, even though I decided to fix bug 886295 another way.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 1: Clean up nsPrintEngine string usage for document titles/URLs

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 2: Clean up string usage for page numbers/formats

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 3: Clean up string usage for printing date/time headers

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 4: Stop heap-allocating nsSharedPageData::mHeadFootFont

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 5: Remove nsSimplePageSequenceFrame::mCurrentPageFrame

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 770022 [details] [diff] [review]
Part 1: Clean up nsPrintEngine string usage for document titles/URLs

In layout/printing/nsPrintEngine.cpp
> nsresult nsPrintEngine::DocumentReadyForPrinting()
> ...
>     // Print Preview -- Pass ownership of docTitleStr and docURLStr
>     // to the pageSequenceFrame, to be displayed in the header
>     nsIPageSequenceFrame *seqFrame = mPrt->mPrintObject->mPresShell->GetPageSequenceFrame();
>     if (seqFrame) {
>       seqFrame->StartPrint(mPrt->mPrintObject->mPresContext, 
>                            mPrt->mPrintSettings, docTitleStr, docURLStr);
>-      docTitleStr = nullptr;
>-      docURLStr = nullptr;
>     }
>   }

Please remove the now obsolete "Pass ownership" comment.

r=mats

Comment 7

[Scoobidiver (away)]

Part 1 pushed to Aurora with no review flag:
http://hg.mozilla.org/releases/mozilla-aurora/rev/5a6f73ab541d

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

That was a mistake. I backed it out in https://hg.mozilla.org/releases/mozilla-aurora/rev/8ac9338cb526.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20b11f54203c
https://hg.mozilla.org/integration/mozilla-inbound/rev/a005d2b576e4
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7af5345cafc
https://hg.mozilla.org/integration/mozilla-inbound/rev/a745c57499ff
https://hg.mozilla.org/integration/mozilla-inbound/rev/c450b3ab8915

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/20b11f54203c
https://hg.mozilla.org/mozilla-central/rev/a005d2b576e4
https://hg.mozilla.org/mozilla-central/rev/c7af5345cafc
https://hg.mozilla.org/mozilla-central/rev/a745c57499ff
https://hg.mozilla.org/mozilla-central/rev/c450b3ab8915
https://hg.mozilla.org/mozilla-central/rev/3467ec69e0dd