889288 - Reduce logging sent to stdout for Marionette

Status: RESOLVED WORKSFORME

(Remote Protocol :: Marionette, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Currently it would appear that any Marionette log statements are printed to stdout. We should either disable this completely (and allow retrieval of logs only through logcat or marionette.get_logs) or increase the log threshold for printing to stdout to WARN.

Bug 883299 introduced some logging whenever touch/mouse events were executed, which caused a lot of noise. They were subsequently disabled in bug 888303. Before we re-enable these, we need to resolve this issue.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

(In reply to Dave Hunt (:davehunt) from comment #0)
> Currently it would appear that any Marionette log statements are printed to
> stdout. We should either disable this completely (and allow retrieval of
> logs only through logcat or marionette.get_logs) or increase the log
> threshold for printing to stdout to WARN.

I think we dump our logs so that it goes into the logcat, so if we disable it completely, we won't get logs in logcat, so increasing the threshold would be better.

When we set up our dump appender logger, we don't specify a log level to the dump appender, we should be able to set it to 'INFO' so it would match the log level of our marionette.log file. If you prefer 'WARN', we can use that.

Comment 2

[Jonathan Griffin (:jgriffin)]

If I understand the original comment correctly, I think it's being suggested we change how the testrunner prints out log statements, rather than how we dump() them from gecko.  E.g., we could have a --console-level argument, similar to mochitest.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Jonathan Griffin (:jgriffin) from comment #2)
> If I understand the original comment correctly, I think it's being suggested
> we change how the testrunner prints out log statements, rather than how we
> dump() them from gecko.  E.g., we could have a --console-level argument,
> similar to mochitest.

Yes, this is really about what we're printing to the console. A --console-level argument would work fine, perhaps with the default level being INFO. Any DEBUG/TRACE level would then not be printed to the console but would be in logcat and available via marionette.get_logs.

Comment 5

[Jonathan Griffin (:jgriffin)]

Whatever solution we implement for this, we should apply to the logger methods that write to marionette.log as well.

Comment 6

[David Burns :automatedtester]

[Mass closure] Closing as these features are no longer needed or wanted

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

For Marionette client and mach there are the -v (DEBUG) and -vv (TRACE) CLI arguments available. When using geckodriver you can specify the log level via FirefoxOptions.

So this request got fixed at some point in the past.