Localize webmaker.org /error.html /search.html /index.html and layout.html

RESOLVED FIXED

Status

Webmaker
webmaker.org
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: alicoding, Assigned: alicoding)

Tracking

Details

(Whiteboard: s=2013w29 p=1)

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Having to localize the whole webmaker.org will take a very long time to do and there are still some pages that might change. I would like to implement the i18n-abide on the webmaker.org first and start with localizing /guides page since this page is very small in content, so that we can see how it goes.
Assignee: nobody → ali
(Assignee)

Updated

4 years ago
Summary: Localize /guides page on webmaker.org → Localize webmaker.org front page
Depends on: 890278
(Assignee)

Updated

4 years ago
Summary: Localize webmaker.org front page → Localize webmaker.org
(Assignee)

Comment 1

4 years ago
I have localized the following pages:

error.html
search.html
index.html
layout.html
Status: NEW → ASSIGNED
Summary: Localize webmaker.org → Localize webmaker.org /error.html /search.html /index.html and layout.html
(Assignee)

Comment 2

4 years ago
Created attachment 773297 [details] [review]
https://github.com/mozilla/webmaker.org/pull/253
Attachment #773297 - Flags: review?(schranz.m)
Attachment #773297 - Flags: review?(david.humphrey)
(Assignee)

Updated

4 years ago
Whiteboard: wb.localization
Depends on: 891491
Comment on attachment 773297 [details] [review]
https://github.com/mozilla/webmaker.org/pull/253

This looks cool, although there are a couple of points to be addressed. We also can't do any local testing until blocking bugs land.
Attachment #773297 - Flags: review?(schranz.m) → review-
(Assignee)

Updated

4 years ago
Whiteboard: wb.localization → s=2013w29 p=1
(Assignee)

Updated

4 years ago
Attachment #773297 - Flags: review?(pomax)
Attachment #773297 - Flags: review?(david.humphrey)
Attachment #773297 - Flags: review-
Comment on attachment 773297 [details] [review]
https://github.com/mozilla/webmaker.org/pull/253

r+, but do file the bug mentioned in the pull request before merge.
Attachment #773297 - Flags: review?(pomax) → review+

Comment 5

4 years ago
Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/58d11559e74b067f772dc5fb7d39cb7f51ab75bb
bug889322 - Localizing webmaker.org
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.