Closed Bug 889329 Opened 11 years ago Closed 11 years ago

Implement SVGSVGElement.deselectAll

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: longsonr, Assigned: longsonr)

References

()

Details

Attachments

(1 file)

Attached patch patchSplinter Review
      No description provided.
Attachment #770136 - Attachment is patch: true
Attachment #770136 - Flags: superreview?(roc)
Attachment #770136 - Flags: review?(cam)
Attachment #770136 - Flags: review?(cam) → review+
It seems strange to have this method on <svg>. Shouldn't it be on all elements, or on the document perhaps? Does anyone actually use it?
SVG does seem to put things that should be on all elements on the root element e.g. getDocumentById, createSVGTransform etc should all be on all elements IMHO.

IE9 implements it: http://msdn.microsoft.com/en-us/library/ie/ff972169%28v=vs.85%29.aspx

As does Batik, Opera and Webkit: http://qt.gitorious.org/qt/releases/blobs/08f7af3fe64037fbe3ec8e638780f9516eb45ca6/src/3rdparty/webkit/WebCore/svg/SVGSVGElement.cpp

So we're the odd ones out.
Assignee: nobody → longsonr
Comment on attachment 770136 [details] [diff] [review]
patch

Review of attachment 770136 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/SVGSVGElement.webidl
@@ +42,5 @@
>    // NodeList getEnclosureList(SVGRect rect, SVGElement referenceElement);
>    // boolean checkIntersection(SVGElement element, SVGRect rect);
>    // boolean checkEnclosure(SVGElement element, SVGRect rect);
> +  [Pref="svg.text.css-frames.enabled"]
> +  void deselectAll();

This doesn't need the pref, the implementation is independent of SVG text.
Attachment #770136 - Flags: superreview?(roc) → superreview+
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/fafa0adecf8b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: