Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mjschranz, Assigned: mjschranz)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Unfortunately it just isn't able to keep up with all of the changes we need. Most of us just run all the apps locally anyway and we don't care about our failing tests right now.
Yeah, it needs to go away.  The way I've been using real servers in travis (see https://github.com/mozilla/MakeAPI/pull/67/files for example) has been working well.

I think the logical thing to do is to clone the server repos you need into test/ when doing a travis run (i.e., do it as a step in travis), then start those servers on localhost:port++, and use them like they were living on the internet.
Comment on attachment 770231 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/84

There is one line left that you may be able to remove?

test/lib.project.test.js:        webfaker.stop(function() {

Is that still there for a reason?

R+ with an answer to that question.
Attachment #770231 - Flags: review?(scott) → review-
(Assignee)

Comment 4

5 years ago
Ooops, missed that one.

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.