Closed Bug 889402 Opened 8 years ago Closed 7 years ago

Refactor MenuPopup to extend ArrowPopup

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: Margaret, Unassigned)

References

Details

We should make MenuPopup extend ArrowPopup, so that we can just have all our arrow positioning code in one place.

We may need to improve ArrowPopup's arrow positioning code for this to work well, but I would prefer for us to just have a really robust ArrowPopup view, rather than re-implementing this positioning logic in different places for different cases.

cc'ing Shilpan, since he's already been messing around with these popups for his page actions work.
Since we removed the arrow from the menu altogether, I assume this bug isn't relevant anymore?
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Good thing we never bothered to fix this bug! :)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.