syncLDAP.pl does not rederive regexp groups when updating login name

RESOLVED FIXED in Bugzilla 4.4

Status

()

Bugzilla
User Accounts
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Pami Ketolainen, Assigned: Pami Ketolainen)

Tracking

4.2.6
Bugzilla 4.4
Bug Flags:
approval +
approval4.4 +

Details

Attachments

(1 attachment)

v1
1.07 KB, patch
Frédéric Buclin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
Created attachment 770221 [details] [diff] [review]
v1

contrib/syncLDAP.pl script uses direct DB query to update the user login names, so the Bugzilla::User->derive_regexp_groups() does not get called.

Attached is a patch to use the User object to do the update.
(Assignee)

Updated

4 years ago
Attachment #770221 - Flags: review?(LpSolit)

Comment 1

4 years ago
Comment on attachment 770221 [details] [diff] [review]
v1

Looks good. r=LpSolit
Attachment #770221 - Flags: review?(LpSolit) → review+

Updated

4 years ago
Assignee: general → pami.ketolainen
Status: UNCONFIRMED → ASSIGNED
Component: Bugzilla-General → User Accounts
Ever confirmed: true
Flags: approval?
Flags: approval4.4?
Target Milestone: --- → Bugzilla 4.4

Updated

4 years ago
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+

Comment 2

4 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified contrib/syncLDAP.pl
Committed revision 8667.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified contrib/syncLDAP.pl
Committed revision 8582.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.