889466 - Lockscreen uses mouse events for gestures when it should be using touch events

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

When attempting to automate gestures on the lockscreen using touch events like other gaia apps, we discovered that the lockscreen is expecting mouse events. When doing a swipe gesture, like the one needed to pull the lockscreen area handle, mouse events are needed, when it should be touch events. This goes against the de-facto standard we're using of 'mouse events for click, touch events for everything else', and so it breaks compatibility with our gesture automation and blocks bug 831852.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Kevin, mind looking into this when you get a chance, per IRC?  Thx :-)

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I'm a little busy with hd+ bugs, maybe Kevin can help on this?

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 772264 [details]
Github pull request pointer

Hi Alive, Yuren,

Wondering if one of you could take a look at the lockscreen patch in this commit. Depending on when you look there may be an extra patch here which fixes gaia in nightly (that is going as part of another bug though).

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 772264 [details]
Github pull request pointer

Code looks OK to me. Feedback? to :yuren.
Though I don't know why two different bug commits are gathered here..

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 772264 [details]
Github pull request pointer

looks good to me, but travis-ci error. I restarted build, so please wait travis result.

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

looks good for second run :D
https://travis-ci.org/mozilla-b2g/gaia/builds/8860879

Comment 8

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/95ab47bbd5bef22050e726d35fd00128f2cc2785

Thanks guys!

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

This patch breaks desktop build since we don't support touchevent there :-o

May need a bug for faking touchevent in desktop build.