Lockscreen uses mouse events for gestures when it should be using touch events

RESOLVED FIXED

Status

Firefox OS
Gaia::System::Lockscreen
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mdas, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: c= p=2)

Attachments

(1 attachment)

When attempting to automate gestures on the lockscreen using touch events like other gaia apps, we discovered that the lockscreen is expecting mouse events. When doing a swipe gesture, like the one needed to pull the lockscreen area handle, mouse events are needed, when it should be touch events. This goes against the de-facto standard we're using of 'mouse events for click, touch events for everything else', and so it breaks compatibility with our gesture automation and blocks bug 831852.
Kevin, mind looking into this when you get a chance, per IRC?  Thx :-)
Flags: needinfo?(kgrandon)
Flags: needinfo?(timdream)
Flags: needinfo?(timdream) → needinfo?(yurenju.mozilla)
I'm a little busy with hd+ bugs, maybe Kevin can help on this?
Flags: needinfo?(yurenju.mozilla)
(Assignee)

Updated

4 years ago
Assignee: nobody → kgrandon
Flags: needinfo?(kgrandon)
Whiteboard: c= p=2
(Assignee)

Comment 3

4 years ago
Created attachment 772264 [details]
Github pull request pointer
(Assignee)

Comment 4

4 years ago
Comment on attachment 772264 [details]
Github pull request pointer

Hi Alive, Yuren,

Wondering if one of you could take a look at the lockscreen patch in this commit. Depending on when you look there may be an extra patch here which fixes gaia in nightly (that is going as part of another bug though).
Attachment #772264 - Flags: review?(yurenju.mozilla)
Attachment #772264 - Flags: review?(alive)
Comment on attachment 772264 [details]
Github pull request pointer

Code looks OK to me. Feedback? to :yuren.
Though I don't know why two different bug commits are gathered here..
Attachment #772264 - Flags: review?(yurenju.mozilla)
Attachment #772264 - Flags: review?(alive)
Attachment #772264 - Flags: review+
Attachment #772264 - Flags: feedback?(yurenju.mozilla)
Comment on attachment 772264 [details]
Github pull request pointer

looks good to me, but travis-ci error. I restarted build, so please wait travis result.
Attachment #772264 - Flags: feedback?(yurenju.mozilla) → feedback+
looks good for second run :D
https://travis-ci.org/mozilla-b2g/gaia/builds/8860879
(Assignee)

Comment 8

4 years ago
Landed in master: https://github.com/mozilla-b2g/gaia/commit/95ab47bbd5bef22050e726d35fd00128f2cc2785

Thanks guys!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
This patch breaks desktop build since we don't support touchevent there :-o

May need a bug for faking touchevent in desktop build.
You need to log in before you can comment on or make changes to this bug.