889468 - [Marketplace][newsletter] country not passed through correctly

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[Jessilyn Davis]

Steps to reproduce:
Set your marketplace language to Brazil
Trigger the email signup form
Sign up

Error found:
"COUNTRY_" field in ET has "us" - not "br"

Expected behavior:
"COUNTRY_" field in ET should be "br"

Comment 1

[Christopher Van Wiemeersch [:cvan]]

(In reply to Jessilyn Davis from comment #0)
> Set your marketplace language to Brazil

Do you mean Portuguese?

Changing your language does not imply that your location has changed. I can speak Portuguese but live in the United States, for example. Do we have a mapping of Basket's expected language->country mappings?

Comment 2

[Jessilyn Davis]

Sorry the bug should have read:

Set your marketplace *country* to Brazil


> Do we have a
> mapping of Basket's expected language->country mappings?

I believe this is something that the Marketplace's particular email form is supposed to set and then pass into basket? Not something that's in basket's logic. 

Davor or pmac, can you confirm?

Comment 3

[Paul [:pmac] McLanahan]

Confirmed. The language and country are sent to basket from the form. It just sends whatever it's sent to Exact Target and doesn't much care about the specific values. The case in which it does care is language if it's not a language supported by our newsletters (de, en, es, fr, id, pt, ru, pl); it throws an error if it's not a member of that set.

Comment 4

[Paul [:pmac] McLanahan]

Also, the names of the fields basket expects are "country" and "lang". "COUNTRY_" is just on the Exact Target side and nothing you need to worry with as clients of basket.

Comment 5

[Jessilyn Davis]

(In reply to Paul McLanahan [:pmac] from comment #3)
> Confirmed. The language and country are sent to basket from the form.

Davor, how is the form configured to send the correct country + language that the user is using Marketplace with?

Comment 6

[Davor Spasovski [:spasovski]]

A POST is sent that looks like "https://marketplace-dev.allizom.org/api/v1/account/newsletter/?_user=---&lang=en-US&pro=8a7dd46e.32.1&region=us"

The API then uses that info but I am not sure how the handoff to Basket is handled. Allen not sure if you have anything to add to this.

Comment 7

[Christopher Van Wiemeersch [:cvan]]

The API is handling this:
https://github.com/mozilla/zamboni/blob/master/mkt/account/api.py#L250-L251

We're sending both region and language. Can you tell me what you expect to happen for a user in region X speaking language Y?

Comment 8

[Jessilyn Davis]

if region = X
and language = Y

the "country" part of the basket API call should be "X"
the "lang" part of the basket API call should be "Y"

If Y is not a language supported by our newsletters (de, en, es, fr, id, pt, ru, pl); basket will throw an error and the subscriber will not be sent to Exact Target (thus the need to show the marketplace form to only people in languages of the newsletter we support).

Comment 9

[Wil Clouser [:clouserw]]

Davor thinks this is a basket issue.  We'll need to debug it with them next week.

Comment 10

[Allen Short [:ashort]]

Testing with curl, the region/lang seem to get transferred to exacttarget correctly. I haven't been able to reproduce any problems with basket or our API call that invokes basket.

Comment 11

[Jessilyn Davis]

Rbillings was able to get the "country" working - this bug is verified working/fixed.

Next up: Make sure language is working correctly.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Jessilyn Davis from comment #11)

> Next up: Make sure language is working correctly.

The language passed from the browser (either desktop or Firefox OS) was re-tested, from https://bugzilla.mozilla.org/show_bug.cgi?id=889468#c8, and looks good (thanks, rbillings, retornam).

Verified FIXED.