889497 - Sidebar docs need polish

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: Documentation, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

I made some really simple documentation, which could probably use a review by Will at the very least.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Assigning this to Will since he i the only one with the polish kit ;)

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #1)
> Assigning this to Will since he i the only one with the polish kit ;)

s/i/is  see what I mean?

Comment 3

[Will Bamberg [:wbamberg]]

Attachment: pullrequest.html

I'm still a bit uncertain about some of this stuff, especially around show/hide and attach/detach. But I thought it's worth having a patch anyway, then we can talk about that.

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 815703 [details]
pullrequest.html

Awesome thanks! just a minor note about the id being optional now.

Comment 5

[Will Bamberg [:wbamberg]]

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #4)
> Comment on attachment 815703 [details]
> pullrequest.html
> 
> Awesome thanks! just a minor note about the id being optional now.


Thnaks Erik! Is it optional in Firefox 26 (Aurora) or not until Firefox 27?

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Will Bamberg [:wbamberg] from comment #5)
> (In reply to Erik Vold [:erikvold] [:ztatic] from comment #4)
> > Comment on attachment 815703 [details]
> > pullrequest.html
> > 
> > Awesome thanks! just a minor note about the id being optional now.
> 
> 
> Thnaks Erik! Is it optional in Firefox 26 (Aurora) or not until Firefox 27?

Ah yes that's right afaict.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/613de5ee8f5db7e81fd2d65416d8760c61a0bbd1
Fix for bug 889497 - Sidebar docs need polish; r=@erikvold

Comment 8

[Will Bamberg [:wbamberg]]

So I've not marked "id" as optional, since these should be for Firefox 26. I'll add that note once I've shipped the Firefox 26 docs.