Closed Bug 889526 Opened 12 years ago Closed 12 years ago

Improve reportError so that it will add a stack trace if one is available

Categories

(DevTools :: Debugger, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 25

People

(Reporter: fitzgen, Assigned: fitzgen)

Details

Attachments

(1 file)

We shouldn't just pass the error on to Cu.reportError. If the argument passed is an error object, we should construct an error message ourselves so that we can make sure we get a stack if one is available.
Assignee: nobody → nfitzgerald
Comment on attachment 770373 [details] [diff] [review] v1 Forgot that robcee is semi-unavailable this week.
Attachment #770373 - Flags: review?(rcampbell) → review?(past)
Comment on attachment 770373 [details] [diff] [review] v1 Review of attachment 770373 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #770373 - Flags: review?(past) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: