Improve reportError so that it will add a stack trace if one is available

RESOLVED FIXED in Firefox 25

Status

RESOLVED FIXED
5 years ago
4 months ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
Firefox 25
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We shouldn't just pass the error on to Cu.reportError. If the argument passed is an error object, we should construct an error message ourselves so that we can make sure we get a stack if one is available.
Assignee: nobody → nfitzgerald
Comment on attachment 770373 [details] [diff] [review]
v1

Forgot that robcee is semi-unavailable this week.
Attachment #770373 - Flags: review?(rcampbell) → review?(past)
Comment on attachment 770373 [details] [diff] [review]
v1

Review of attachment 770373 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #770373 - Flags: review?(past) → review+
https://hg.mozilla.org/mozilla-central/rev/18bf64501c80
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.