Convert front page to load initial makes server-side

RESOLVED FIXED

Status

Webmaker
webmaker.org
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: inactivate account for kate, Assigned: inactivate account for kate)

Tracking

Details

(Whiteboard: s=2013w29 p=1)

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
This will improve performance, particularly on mobile devices. See bug 889549 for a longer description of why this is a good idea.

Personally I think we should consider alternatives to the flip interaction to improve performance/mobile UX as well but we should discuss that elsewhere.
(Assignee)

Updated

4 years ago
Blocks: 884976
(Assignee)

Updated

4 years ago
Assignee: nobody → kate
(Assignee)

Updated

4 years ago
Whiteboard: s=2013w29
(Assignee)

Comment 1

4 years ago
Created attachment 776650 [details] [review]
https://github.com/mozilla/webmaker.org/pull/272
Attachment #776650 - Flags: review?(jon)
(Assignee)

Updated

4 years ago
Attachment #776650 - Flags: feedback?(gavin)
(Assignee)

Updated

4 years ago
Attachment #776650 - Flags: feedback?(gavin) → feedback?
(Assignee)

Updated

4 years ago
Attachment #776650 - Flags: review?(jon) → review?(schranz.m)

Updated

4 years ago
Whiteboard: s=2013w29 → s=2013w29 p=1
Comment on attachment 776650 [details] [review]
https://github.com/mozilla/webmaker.org/pull/272

Lot's of comments. Some general nits, but a lot of questions. There's just things I'm not understanding about how nunjucks determines what is being rendered.

Also, I'd encourage getting someone else to look over this. I don't trust my reviews right now for single reviewing.
Attachment #776650 - Flags: review?(schranz.m)
Attachment #776650 - Flags: review-
Attachment #776650 - Flags: feedback?
Require.js errors on the following pages:

/events
/tools
Comment on attachment 776650 [details] [review]
https://github.com/mozilla/webmaker.org/pull/272

Been lots of reviews since.

R+
Attachment #776650 - Flags: review- → review+

Comment 5

4 years ago
Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/3f3b0c95d651d68afef9312a030bad4296e5ea2f
[bug 889552] Refactored front page and other pages to use only app.js, gallery and packery functionality into a single gallery.js file
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.