bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Test management of the linked list of multiview ArrayBufferObjects in the overflow case where obj_trace is called multiple times

RESOLVED FIXED in mozilla25

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

unspecified
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
There's an assert that is currently never triggered by the test suite, and which is totally buggy besides.
(Assignee)

Comment 1

5 years ago
Created attachment 770391 [details] [diff] [review]
Test management of the linked list of multiview ArrayBufferObjects in the overflow case where obj_trace is called multiple times

This patch adds a gcparam('markStackLimit', N) call that may be used to test mark stack overflow, since that's the only way to get obj_trace called multiple times on the same object.
Attachment #770391 - Flags: review?(wmccloskey)
(Assignee)

Updated

5 years ago
Depends on: 889146
Attachment #770391 - Flags: review?(wmccloskey) → review+
The jstypedarray.cpp change ended up going into part 8 of bug 889146.  Here's the landing of the test, though:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35ce088f84a0
https://hg.mozilla.org/mozilla-central/rev/35ce088f84a0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25

Comment 4

5 years ago
gcparam("markStackLimit") was initially added in bug 673551:
https://hg.mozilla.org/mozilla-central/rev/fad8d2718cd0

removed, apparently by accident, in bug 729369:
https://hg.mozilla.org/mozilla-central/rev/cfa346e78b0d

and re-added here in bug 889559:
https://hg.mozilla.org/mozilla-central/rev/35ce088f84a0
You need to log in before you can comment on or make changes to this bug.